lnprototest: refactroing abstract class and fixed the #14#38
Merged
vincenzopalazzo merged 7 commits intorustyrussell:masterfrom Mar 9, 2022
Merged
Conversation
kill all the process when the class was removed from the scope. Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
335ca4d to
4b4823c
Compare
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Collaborator
Author
|
ack 66b5a94 |
This was referenced Mar 15, 2022
defi-knightxnhu89
added a commit
to defi-knightxnhu89/lnprototest
that referenced
this pull request
Sep 29, 2025
…class and fixed the #14 66b5a941b64368506ac9f90ccd5ff1e4f83b52f9 lnprototest: remove the default __enter__ __exit__ implementation (Vincenzo Palazzo) fd9bae5e117330d8580573d5d05eba4a2b11f659 lnprototest: remove info logging when it is not necessary (Vincenzo Palazzo) c7144c553864a799c2d1dc1b3e1c38927601a8b4 doc: adding log information in the Readme (Vincenzo Palazzo) 8ff83a991dfa24e3ebc38357f627660d9af95249 ci: during the test in the ci increase verbosity of the tests (Vincenzo Palazzo) 363b9e54222bb1ad83671e18d4a89827310c8511 lnprototest: adding teardown directory at the end of the tests (Vincenzo Palazzo) 4b4823c0702cc1cd57fb491b9c497bad1f4bc369 fmt: formatting code (Vincenzo Palazzo) e0cce0a4b1645d41e9b411a2f6ce85af4f062640 lnprototest: refactroing abstract class and fixed the #14 (Vincenzo Palazzo) Pull request description: kill all the processes when the class was removed from the scope. Fixes #14 This is a refactoring PR cherry-pitched by the PR rustyrussell/lnprototest#37 but it is cleaner to introduce these changes in another PR. Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com> Top commit has no ACKs. Tree-SHA512: f2bd5f609caecd9a9bb3bfcd4f02fe7bd73a69a63265c5ee9fca73b7c34116ea044c84fabec0c3d009f7604e63121c0d18fa0f54d5eda19cf730130d8f55d0d1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kill all the processes when the class was removed from the scope.
Fixes #14
This is a refactoring PR cherry-pitched by the PR #37 but it is cleaner to introduce these changes in another PR.
Signed-off-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com