coop-close channel integration testing by vincenzopalazzo · Pull Request #37 · rustyrussell/lnprototest

vincenzopalazzo · 2022-03-03T14:08:41Z

Build on top of #47

This is one of my first attempts to implement the interoperability test for the shutdown workflow described in BOLT2

This should clarify the idea on the implementation side about the following discussion lightning/bolts#964 and lightning/bolts#970

This will override the c-lightning CI flaky test https://github.com/ElementsProject/lightning/pull/4985/files/93f8a11bf60ad9809ced69c9be0ae7ccf922b2eb..7530018014128a24a42f816ab0676cb85f9e96c8#diff-72d78e7a968ac6b078b7a2d84e56d2e026c54f60e56781f878664bcaae4b2bfbR3441

66b5a94 lnprototest: remove the default __enter__ __exit__ implementation (Vincenzo Palazzo) fd9bae5 lnprototest: remove info logging when it is not necessary (Vincenzo Palazzo) c7144c5 doc: adding log information in the Readme (Vincenzo Palazzo) 8ff83a9 ci: during the test in the ci increase verbosity of the tests (Vincenzo Palazzo) 363b9e5 lnprototest: adding teardown directory at the end of the tests (Vincenzo Palazzo) 4b4823c fmt: formatting code (Vincenzo Palazzo) e0cce0a lnprototest: refactroing abstract class and fixed the #14 (Vincenzo Palazzo) Pull request description: kill all the processes when the class was removed from the scope. Fixes #14 This is a refactoring PR cherry-pitched by the PR #37 but it is cleaner to introduce these changes in another PR. Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com> Top commit has no ACKs. Tree-SHA512: f2bd5f609caecd9a9bb3bfcd4f02fe7bd73a69a63265c5ee9fca73b7c34116ea044c84fabec0c3d009f7604e63121c0d18fa0f54d5eda19cf730130d8f55d0d1

michaelfolkson · 2022-03-17T11:28:21Z

Concept ACK. More testing around cooperative closing is good :)

The motivation for this (as I understand from the c-lightning call) is when a lnprototest test fails bitcoind isn't stopped? Firstly I'm not sure why bitcoind should be stopped if a lnprototest test fails (I guess it depends on the test) and secondly I'm not sure how the code in this PR resolves that. Can you explain?

vincenzopalazzo · 2022-03-18T10:59:32Z

Concept ACK. More testing around cooperative closing is good :)

Yes, also because we have a little bit of confusion across definition of coop-close in the spec like lightning/bolts#970 (comment) and lightning/bolts#964

The motivation for this (as I understand from the c-lightning call) is when a lnprototest test fails bitcoind isn't stopped? Firstly I'm not sure why bitcoind should be stopped if a lnprototest test fails (I guess it depends on the test) and secondly I'm not sure how the code in this PR resolves that. Can you explain?

Sorry if I miss the point to the PR, this problem is fixed by the following PR #38 In particular if a test fails or lnprototest was not able to clear the work dir in the /tmp and sto bitcoind to work because the following code was missing

lnprototest/lnprototest/clightning/clightning.py

Lines 166 to 170 in ceeb866

    
           def shutdown(self) -> None: 
        
               for cb in self.cleanup_callbacks: 
        
                   cb() 
        
               self.rpc.stop() 
        
               self.bitcoind.stop()

and also all the lnprototest flow between start -> shutdown -> stop was rewritten

tests/test_bolt2-01-close_channel.py

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com> # Title: Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

vincenzopalazzo · 2022-09-19T15:55:28Z

ovveride by #62

…class and fixed the #14 66b5a941b64368506ac9f90ccd5ff1e4f83b52f9 lnprototest: remove the default __enter__ __exit__ implementation (Vincenzo Palazzo) fd9bae5e117330d8580573d5d05eba4a2b11f659 lnprototest: remove info logging when it is not necessary (Vincenzo Palazzo) c7144c553864a799c2d1dc1b3e1c38927601a8b4 doc: adding log information in the Readme (Vincenzo Palazzo) 8ff83a991dfa24e3ebc38357f627660d9af95249 ci: during the test in the ci increase verbosity of the tests (Vincenzo Palazzo) 363b9e54222bb1ad83671e18d4a89827310c8511 lnprototest: adding teardown directory at the end of the tests (Vincenzo Palazzo) 4b4823c0702cc1cd57fb491b9c497bad1f4bc369 fmt: formatting code (Vincenzo Palazzo) e0cce0a4b1645d41e9b411a2f6ce85af4f062640 lnprototest: refactroing abstract class and fixed the #14 (Vincenzo Palazzo) Pull request description: kill all the processes when the class was removed from the scope. Fixes #14 This is a refactoring PR cherry-pitched by the PR rustyrussell/lnprototest#37 but it is cleaner to introduce these changes in another PR. Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com> Top commit has no ACKs. Tree-SHA512: f2bd5f609caecd9a9bb3bfcd4f02fe7bd73a69a63265c5ee9fca73b7c34116ea044c84fabec0c3d009f7604e63121c0d18fa0f54d5eda19cf730130d8f55d0d1

vincenzopalazzo added the enhancement New feature or request label Mar 3, 2022

vincenzopalazzo mentioned this pull request Mar 3, 2022

lnprototest: refactroing abstract class and fixed the #14 #38

Merged

vincenzopalazzo marked this pull request as draft March 3, 2022 14:11

vincenzopalazzo force-pushed the vincenzopalazzo/bolt2_close_channel branch 2 times, most recently from c464f7d to f202fb3 Compare March 15, 2022 16:47

vincenzopalazzo added SPEC Related to lightning network specification SPEC: BOLT 2 Related to BOLT 2 in general and removed enhancement New feature or request labels Mar 15, 2022

vincenzopalazzo self-assigned this Mar 15, 2022

vincenzopalazzo force-pushed the vincenzopalazzo/bolt2_close_channel branch 3 times, most recently from 42c10dc to 4ca53ae Compare March 15, 2022 17:10

vincenzopalazzo force-pushed the vincenzopalazzo/bolt2_close_channel branch 4 times, most recently from 442f33e to 3932da3 Compare March 24, 2022 10:23

vincenzopalazzo changed the title ~~[WIP] coop-close channel integration testing~~ coop-close channel integration testing Mar 24, 2022

vincenzopalazzo force-pushed the vincenzopalazzo/bolt2_close_channel branch from 3932da3 to 7f1ba78 Compare March 24, 2022 10:27

vincenzopalazzo requested a review from rustyrussell March 24, 2022 10:27

vincenzopalazzo force-pushed the vincenzopalazzo/bolt2_close_channel branch 8 times, most recently from c1ff0a1 to 1c6c016 Compare March 30, 2022 16:40

vincenzopalazzo marked this pull request as ready for review March 30, 2022 21:01

vincenzopalazzo force-pushed the vincenzopalazzo/bolt2_close_channel branch 3 times, most recently from 046d5c0 to 1a5de7b Compare March 31, 2022 07:55

vincenzopalazzo mentioned this pull request Apr 1, 2022

BOLT#02: clarify coop close requirements lightning/bolts#970

Merged

vincenzopalazzo force-pushed the vincenzopalazzo/bolt2_close_channel branch 2 times, most recently from aadd90b to 0d4d793 Compare April 6, 2022 14:07

vincenzopalazzo mentioned this pull request Apr 6, 2022

BOLT 2: forget the check about update_* messages, and check what must not happens during shutdown lightning/bolts#972

Closed

vincenzopalazzo force-pushed the vincenzopalazzo/bolt2_close_channel branch from 0d4d793 to 127fd9f Compare April 6, 2022 14:32

vincenzopalazzo added the SPEC: BOLT 2 - Close Channel Related to BOLT 2, with more focus to the close channel side label Apr 6, 2022

vincenzopalazzo mentioned this pull request Apr 6, 2022

pyln-spec: upgrade to the last bolt version ElementsProject/lightning#5168

Merged

vincenzopalazzo force-pushed the vincenzopalazzo/bolt2_close_channel branch from 7bc966c to 4b15032 Compare April 9, 2022 13:33

michiboo reviewed Apr 10, 2022

View reviewed changes

tests/test_bolt2-01-close_channel.py Outdated Show resolved Hide resolved

michiboo reviewed Apr 10, 2022

View reviewed changes

tests/test_bolt2-01-close_channel.py Outdated Show resolved Hide resolved

vincenzopalazzo force-pushed the vincenzopalazzo/bolt2_close_channel branch from 67c3a4f to 31f7da7 Compare April 26, 2022 09:25

vincenzopalazzo mentioned this pull request Apr 29, 2022

bolt2: shutdown adventure lightning/bolts#985

Closed

vincenzopalazzo force-pushed the vincenzopalazzo/bolt2_close_channel branch from bc2c4de to e53a8bf Compare May 10, 2022 21:59

vincenzopalazzo mentioned this pull request May 23, 2022

core-lightning: restart bitcoind when we're restarted. #52

Closed

vincenzopalazzo force-pushed the vincenzopalazzo/bolt2_close_channel branch from e53a8bf to 7831416 Compare July 29, 2022 15:40

vincenzopalazzo force-pushed the vincenzopalazzo/bolt2_close_channel branch from b1677ca to a889aad Compare September 19, 2022 14:40

ci: improve the integration testing procedure

ea6f38c

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

vincenzopalazzo force-pushed the vincenzopalazzo/bolt2_close_channel branch 2 times, most recently from f51122b to 4b1a993 Compare September 19, 2022 15:48

vincenzopalazzo added 3 commits September 19, 2022 16:48

lnprototest: improve the log information

7bdf433

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com> # Title: Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

test: add util spec to avoid code duplication that need to be mantained

8bc2e0c

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

bolt2: add coop close test

ed9d1d6

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

vincenzopalazzo force-pushed the vincenzopalazzo/bolt2_close_channel branch from 4b1a993 to ed9d1d6 Compare September 19, 2022 15:48

vincenzopalazzo closed this Sep 19, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

coop-close channel integration testing#37

coop-close channel integration testing#37
vincenzopalazzo wants to merge 4 commits intorustyrussell:masterfrom
vincenzopalazzo:vincenzopalazzo/bolt2_close_channel

vincenzopalazzo commented Mar 3, 2022 •

edited

Loading

Uh oh!

michaelfolkson commented Mar 17, 2022

Uh oh!

vincenzopalazzo commented Mar 18, 2022

Uh oh!

Uh oh!

Uh oh!

vincenzopalazzo commented Sep 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

vincenzopalazzo commented Mar 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michaelfolkson commented Mar 17, 2022

Uh oh!

vincenzopalazzo commented Mar 18, 2022

Uh oh!

Uh oh!

Uh oh!

vincenzopalazzo commented Sep 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vincenzopalazzo commented Mar 3, 2022 •

edited

Loading