refactor(backend): migrate from backoff to backon#356
refactor(backend): migrate from backoff to backon#356simonsan merged 8 commits intorustic-rs:mainfrom
backoff to backon#356Conversation
f61ce42 to
6bae412
Compare
backoff to backon
|
Actually I didn't get what the benefit was using |
Hello, Thanks for taking a look and contributing. The extension was replacing what backoff did and backon didn't. The way I did it could make it easy to reuse the retry in some other backend or other places in the code, or even propose the ideas to backon. But If you anticipate we won't need it elsewhere I don't mind moving the logic to |
Also added doc
## 🤖 New release * `rustic_backend`: 0.4.2 -> 0.5.0 (⚠️ API breaking changes) * `rustic_core`: 0.5.5 -> 0.6.0 (⚠️ API breaking changes) * `rustic_testing`: 0.2.3 -> 0.3.0 (✓ API compatible changes) ###⚠️ `rustic_backend` breaking changes ``` --- failure enum_missing: pub enum removed or renamed --- Description: A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.36.0/src/lints/enum_missing.ron Failed in: enum rustic_backend::error::LocalBackendErrorKind, previously in file /tmp/.tmp0sSY8G/rustic_backend/src/error.rs:90 enum rustic_backend::error::RestErrorKind, previously in file /tmp/.tmp0sSY8G/rustic_backend/src/error.rs:67 enum rustic_backend::error::BackendAccessErrorKind, previously in file /tmp/.tmp0sSY8G/rustic_backend/src/error.rs:10 enum rustic_backend::error::RcloneErrorKind, previously in file /tmp/.tmp0sSY8G/rustic_backend/src/error.rs:43 --- failure module_missing: pub module removed or renamed --- Description: A publicly-visible module cannot be imported by its prior path. A `pub use` may have been removed, or the module may have been renamed, removed, or made non-public. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.36.0/src/lints/module_missing.ron Failed in: mod rustic_backend::error, previously in file /tmp/.tmp0sSY8G/rustic_backend/src/error.rs:1 ``` ###⚠️ `rustic_core` breaking changes ``` --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.36.0/src/lints/inherent_method_missing.ron Failed in: LocalDestination::remove_dir, previously in file /tmp/.tmp0sSY8G/rustic_core/src/backend/local_destination.rs:129 LocalDestination::remove_file, previously in file /tmp/.tmp0sSY8G/rustic_core/src/backend/local_destination.rs:152 LocalDestination::create_dir, previously in file /tmp/.tmp0sSY8G/rustic_core/src/backend/local_destination.rs:171 LocalDestination::set_times, previously in file /tmp/.tmp0sSY8G/rustic_core/src/backend/local_destination.rs:189 LocalDestination::set_user_group, previously in file /tmp/.tmp0sSY8G/rustic_core/src/backend/local_destination.rs:237 LocalDestination::set_uid_gid, previously in file /tmp/.tmp0sSY8G/rustic_core/src/backend/local_destination.rs:283 LocalDestination::set_permission, previously in file /tmp/.tmp0sSY8G/rustic_core/src/backend/local_destination.rs:324 LocalDestination::set_extended_attributes, previously in file /tmp/.tmp0sSY8G/rustic_core/src/backend/local_destination.rs:385 LocalDestination::set_length, previously in file /tmp/.tmp0sSY8G/rustic_core/src/backend/local_destination.rs:466 LocalDestination::create_special, previously in file /tmp/.tmp0sSY8G/rustic_core/src/backend/local_destination.rs:521 LocalDestination::read_at, previously in file /tmp/.tmp0sSY8G/rustic_core/src/backend/local_destination.rs:599 LocalDestination::write_at, previously in file /tmp/.tmp0sSY8G/rustic_core/src/backend/local_destination.rs:663 RusticError::into_inner, previously in file /tmp/.tmp0sSY8G/rustic_core/src/error.rs:46 RusticError::backend_error, previously in file /tmp/.tmp0sSY8G/rustic_core/src/error.rs:61 ``` <details><summary><i><b>Changelog</b></i></summary><p> ## `rustic_backend` <blockquote> ## [0.5.0](rustic_backend-v0.4.2...rustic_backend-v0.5.0) - 2024-11-18 ### Added - *(async)* add `async_compatible` methods to identify backend compatibility ([#355](#355)) - add 'yandex-disk' to enabled opendal services and update opendal to 0.50.2 ([#360](#360)) ### Other - *(error)* enhance error logging and output formatting ([#361](#361)) - *(backend)* simplify code in local backend ([#362](#362)) - *(backend)* migrate from `backoff` to `backon` ([#356](#356)) - *(error)* improve error messages and file handling ([#334](#334)) - *(deps)* lock file maintenance rust dependencies ([#345](#345)) - *(deps)* [**breaking**] upgrade to new conflate version ([#300](#300)) - *(errors)* [**breaking**] Improve error handling, display and clean up codebase ([#321](#321)) </blockquote> ## `rustic_core` <blockquote> ## [0.6.0](rustic_core-v0.5.5...rustic_core-v0.6.0) - 2024-11-18 ### Added - *(async)* add `async_compatible` methods to identify backend compatibility ([#355](#355)) ### Fixed - prevent overwriting hot repository on init ([#353](#353)) ### Other - *(error)* enhance error logging and output formatting ([#361](#361)) - *(deps)* remove Derivative and replace with Default impl due to RUSTSEC-2024-0388 ([#359](#359)) - *(error)* improve error messages and file handling ([#334](#334)) - *(deps)* lock file maintenance rust dependencies ([#345](#345)) - *(deps)* remove cdc and switch to rustic_cdc ([#348](#348)) - *(deps)* [**breaking**] upgrade to new conflate version ([#300](#300)) - *(errors)* [**breaking**] Improve error handling, display and clean up codebase ([#321](#321)) </blockquote> ## `rustic_testing` <blockquote> ## [0.3.0](rustic_testing-v0.2.3...rustic_testing-v0.3.0) - 2024-11-18 ### Added - *(async)* add `async_compatible` methods to identify backend compatibility ([#355](#355)) ### Other - *(errors)* [**breaking**] Improve error handling, display and clean up codebase ([#321](#321)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: rustic-release-plz[bot] <182542030+rustic-release-plz[bot]@users.noreply.github.com>
Hello,
Removed the unmaintained
backoffcrate in therustic_backendcrate.Replaced it with the relatively similar
backoncrate.If
backonas simpler API, it also lacks a few features thatbackoffhad.For instance:
no_max_delayorbackoff::retry_notify.To make up for it:
backongithub.backon_extensioninsidebackend::rest.Let me know what you think of the code!
Fixes #351