feat: builder_without_max_(times|delay)#160
Merged
Xuanwo merged 5 commits intoXuanwo:mainfrom Nov 22, 2024
Merged
Conversation
Contributor
Author
|
I have no idea why the |
github-merge-queue bot
pushed a commit
to rustic-rs/rustic_core
that referenced
this pull request
Nov 18, 2024
Hello, Removed the unmaintained `backoff` crate in the `rustic_backend` crate. Replaced it with the relatively similar `backon` crate. If `backon` as simpler API, it also lacks a few features that `backoff` had. For instance: `no_max_delay` or `backoff::retry_notify`. To make up for it: - I opened Xuanwo/backon#160 on the `backon` github. - I implemented an internal module `backon_extension` inside `backend::rest`. Let me know what you think of the code! Fixes #351 --------- Co-authored-by: Alexander Weiss <alex@weissfam.de> Co-authored-by: simonsan <14062932+simonsan@users.noreply.github.com>
Owner
Let me take a look over this. |
|
Thank you very much for implementing this! 🫶 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Fix issue #158 by adding
without_max_delayandwithout_max_timesto fibonacci and exponential backoffs.Also added
without_max_timesfor constant backoff.