Make keyboard input event order consistent#173
Merged
tomaka merged 1 commit intorust-windowing:masterfrom May 8, 2017
Merged
Conversation
All platforms should now receive events in the following order: 1. KeyboardInput(ElementState::Pressed, ..) 2. ReceivedCharacter 3. KeyboardInput(ElementState::Released, ..) cc rust-windowing/glutin#878
Contributor
Author
|
This updates X11 and Cocoa event orderings to match Win32. I don't have the means to test Wayland so I did not look into it. |
Contributor
|
Thanks |
Contributor
|
FTR, Wayland was already following this order, see https://github.com/tomaka/winit/blob/master/src/platform/linux/wayland/keyboard.rs#L41-L64 |
Contributor
Author
Contributor
|
I'm still unsure if this is the right API or not, but I guess why not. |
6 tasks
tmfink
pushed a commit
to tmfink/winit
that referenced
this pull request
Jan 5, 2022
Start adding tests for scalar::F32x4
madsmtm
pushed a commit
to madsmtm/winit
that referenced
this pull request
Jun 11, 2022
* Update to gtk v0.14 * fix: rust-windowing#167 - Change dependency from libappindicator to libayatana-appindicator (rust-windowing#168) * feat(tray): Changed to libayatana-appindicator-rs. * Update CI script Co-authored-by: Ngo Iok Ui <wusyong9104@gmail.com> * Update libappindicator crate * Update ci script * Add change file Co-authored-by: Lewin Probst, M.Sc <30552361+emirror-de@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All platforms should now receive events in the following order:
cc rust-windowing/glutin#878