Set WM_CLASS and WM_NAME before mapping window#168
Merged
tomaka merged 1 commit intorust-windowing:masterfrom May 5, 2017
jonhoo:set_class_before_map
Merged
Set WM_CLASS and WM_NAME before mapping window#168tomaka merged 1 commit intorust-windowing:masterfrom jonhoo:set_class_before_map
tomaka merged 1 commit intorust-windowing:masterfrom
jonhoo:set_class_before_map
Conversation
ICCCM 4.1.2.5 (https://tronche.com/gui/x/icccm/sec-4.html#WM_CLASS) states that: > This property must be present when the window leaves the Withdrawn > state and may be changed only while the window is in the Withdrawn > state. Previously, we would first map the window, and then set these properties, causing sadness for window managers (#167, rust-windowing/glutin#879). This patch changes that by setting the class and name attributes immediately after the window is created, and before it is mapped. Fixes #167.
Contributor
|
Thanks! |
This was referenced May 7, 2017
Closed
tmfink
pushed a commit
to tmfink/winit
that referenced
this pull request
Jan 5, 2022
Fix unused variable warning
madsmtm
pushed a commit
to madsmtm/winit
that referenced
this pull request
Jun 11, 2022
* Update to gtk v0.14 * fix: rust-windowing#167 - Change dependency from libappindicator to libayatana-appindicator (rust-windowing#168) * feat(tray): Changed to libayatana-appindicator-rs. * Update CI script Co-authored-by: Ngo Iok Ui <wusyong9104@gmail.com> * Update libappindicator crate * Update ci script * Add change file Co-authored-by: Lewin Probst, M.Sc <30552361+emirror-de@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ICCCM 4.1.2.5 states that:
Previously, we would first map the window, and then set these properties, causing sadness for window managers (#167, rust-windowing/glutin#879). This patch changes that by setting the class and name attributes immediately after the window is created, and before it is mapped.
Fixes #167.