Merged
Conversation
- Unwrap env variables only when required. - Handle cases where `CARGO_CFG_TARGET_FAMILY` is not set. There is no need to unwrap this env var since we are only using it to optionally set some compiler flags. - For wasm builds, define `ONIG_DISABLE_DIRECT_THREADING`. This is a new macro in oniguruma which disables computed gotos, which are unsupported by clang-8 when compiling to wasm targets. - Override `ONIG_EXTERN` to set function visibility for wasm builds. By default, functions are not exported under wasm targets. This flag ensures all functions in the static onig library are marked exported. - Set `-fvisibility=default` for bindgen runs on wasm targets.
Bumps [bindgen](https://github.com/rust-lang/rust-bindgen) from 0.54.1 to 0.55.1. - [Release notes](https://github.com/rust-lang/rust-bindgen/releases) - [Changelog](https://github.com/rust-lang/rust-bindgen/blob/master/CHANGELOG.md) - [Commits](rust-lang/rust-bindgen@v0.54.1...v0.55.1)
Collaborator
Author
|
Looks like the bump in Bindgen version causes a CI failure due to bumping the minimum Rust version. Do we know what the minimum Version should be now? |
Contributor
|
The change in MSRV comes from a clang-sys upgrade to v1.0.0. It looks like bindgen now requires Rust 1.40.0 |
lopopolo
approved these changes
Sep 8, 2020
Contributor
lopopolo
left a comment
There was a problem hiding this comment.
LGTM. Thanks for upstreaming
iwillspeak
added a commit
that referenced
this pull request
Sep 9, 2020
Needed for the latest version of `clang-sys`. See <#147 (comment)> for more information.
iwillspeak
added a commit
that referenced
this pull request
Sep 9, 2020
Needed for the latest version of `clang-sys`. See <#147 (comment)> for more information.
Merged
iwillspeak
added a commit
that referenced
this pull request
Sep 9, 2020
Needed for the latest version of `clang-sys`. See <#147 (comment)> for more information.
iwillspeak
added a commit
that referenced
this pull request
Sep 9, 2020
Needed for the latest version of `clang-sys`. See <#147 (comment)> for more information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WASM Work from Artichoke courtesy of @lopopolo. Supersedes #122.