Skip empty matches only when they overlap last match#145
Merged
iwillspeak merged 2 commits intorust-onig:mainfrom Sep 9, 2020
Merged
Skip empty matches only when they overlap last match#145iwillspeak merged 2 commits intorust-onig:mainfrom
iwillspeak merged 2 commits intorust-onig:mainfrom
Conversation
Previously, attempting to `split` around a delimiter would fail if that delimiter was preceded by any positive length match.
iwillspeak
approved these changes
Sep 8, 2020
Collaborator
iwillspeak
left a comment
There was a problem hiding this comment.
This looks like a decent solution to the problem. I’m happy to merge.
Contributor
Author
|
Great, thanks for the review! Is there anything else you need from me on this PR? |
Collaborator
|
Was just waiting for the bump in minimum supported rust version before merging. This should |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, attempting to
splitaround a delimiter would fail if that delimiter was preceded by any positive length match.In my case, I was trying to use
splitto consume blank delimiters, but yield quote delimiters. I ended up writing a test like:But it was failing to split on the zero-width position before the quote:
With this change, my test now passes. What do you think of it?