Lifetime variance fixes for rustc#97292
Merged
bors merged 1 commit intorust-lang:masterfrom May 23, 2022
Merged
Conversation
Contributor
|
Some changes occured to the CTFE / Miri engine cc @rust-lang/miri Some changes occured to the CTFE / Miri engine cc @rust-lang/miri |
Contributor
|
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
davidtwco
approved these changes
May 23, 2022
Member
davidtwco
left a comment
There was a problem hiding this comment.
I'm not familiar with all of the parts of the compiler this changes, but this seems fairly straigthforward so LGTM.
Member
|
@bors r+ |
Collaborator
|
📌 Commit 1784634 has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 23, 2022
Rollup of 4 pull requests Successful merges: - rust-lang#96129 (Document rounding for floating-point primitive operations and string parsing) - rust-lang#97286 (Add new eslint rule to prevent whitespace before function call paren) - rust-lang#97292 (Lifetime variance fixes for rustc) - rust-lang#97309 (Add some regression tests for rust-lang#90400) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#97287 migrates rustc to a
Tytype that is invariant over its lifetime'tcx, so I need to fix a bunch of places that assume thatTy<'a>andTy<'b>can be unified by shortening both to some common lifetime.This is doable, since many lifetimes are already
'tcx, so all this PR does is be a bit more explicit that elided lifetimes are actually'tcx.Split out from #97287 so the compiler team can review independently.