Document rounding for floating-point primitive operations and string parsing#96129
Merged
bors merged 2 commits intorust-lang:masterfrom May 23, 2022
Merged
Document rounding for floating-point primitive operations and string parsing#96129bors merged 2 commits intorust-lang:masterfrom
bors merged 2 commits intorust-lang:masterfrom
Conversation
State that the four primitive operations honour IEEE 754 roundTiesToEven. Documenting under "Primitive Type f32"; f64 refers to that.
Contributor
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @scottmcm (or someone else) soon. Please see the contribution instructions for more information. |
Contributor
Author
|
r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs |
Member
|
@bors r+ rollup |
Collaborator
|
📌 Commit 16c81fa has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 23, 2022
Rollup of 4 pull requests Successful merges: - rust-lang#96129 (Document rounding for floating-point primitive operations and string parsing) - rust-lang#97286 (Add new eslint rule to prevent whitespace before function call paren) - rust-lang#97292 (Lifetime variance fixes for rustc) - rust-lang#97309 (Add some regression tests for rust-lang#90400) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs for floating point don't have much to say at present about either the precision of their results or rounding behaviour.
As I understand it12, Rust doesn't support operating with non-default rounding directions, so we need only describe roundTiesToEven.
This PR makes a start by documenting that for primitive operations and
from_str().Footnotes
https://github.com/rust-lang/rust/issues/41753#issuecomment-299322887 ↩
https://github.com/llvm/llvm-project/issues/8472#issuecomment-980888781 ↩