Fix STD compilation for the ESP-IDF target (regression from CVE-2022-21658)#93152
Merged
bors merged 1 commit intorust-lang:masterfrom Jan 24, 2022
Merged
Fix STD compilation for the ESP-IDF target (regression from CVE-2022-21658)#93152bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
r? @dtolnay (rust-highfive has picked a reviewer for you, use r? to override) |
Member
|
@bors r+ |
Collaborator
|
📌 Commit 495c7b3 has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 24, 2022
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#92513 (std: Implement try_reserve and try_reserve_exact on PathBuf) - rust-lang#93152 (Fix STD compilation for the ESP-IDF target (regression from CVE-2022-21658)) - rust-lang#93186 (Fix link to CVE-2022-21658) - rust-lang#93188 (rustdoc: fix bump down typing search on Safari) - rust-lang#93212 (Remove unneeded cursor pointer rule on mobile sidebar) - rust-lang#93231 (adjust sidebar link brightness) - rust-lang#93241 (Fix brief appearance of rust logo in the sidebar) - rust-lang#93253 (Update theme on pageshow event) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 54e22eb broke the compilation of STD for the ESP-IDF embedded "unix-like" Tier 3 target, because the fix for CVE-2022-21658 uses libc flags which are not supported on the ESP-IDF platform.
This PR simply redirects the ESP-IDF compilation to the "classic" implementation, similar to REDOX. This should be safe because: