Initial metrics support#8646
Closed
emberian wants to merge 1 commit intorust-lang:masterfrom
emberian:metrics
Closed
Initial metrics support#8646emberian wants to merge 1 commit intorust-lang:masterfrom emberian:metrics
emberian wants to merge 1 commit intorust-lang:masterfrom
emberian:metrics
Conversation
Contributor
|
I keep writing up then losing the comments I wanted to make here. I think I'd prefer the following changes:
Mostly I just want this interface to be as simple as possible so that people use it casually. Best usage I can picture is like: Most of this can be done as followon commits (which I'm happy to help with), but I think |
Contributor
Author
|
@graydon I'm going to close this to clear up the queue as I don't foresee getting a chance to work on it in the next week, but if you don't get to it (I understand you're on vacation) I'll pick it up as soon as I can. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 7, 2022
…fate Fix `as_deref_mut` false positives in `needless_option_as_deref` Also moves it into `methods/` Fixes rust-lang#7846 Fixes rust-lang#8047 changelog: [`needless_option_as_deref`]: No longer lints for `as_deref_mut` on Options that cannot be moved supersedes rust-lang#8064
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 21, 2022
…rednet Check for loops/closures in `local_used_after_expr` Follow up to rust-lang#8646, catches when a local is used multiple times because it's in a loop or a closure changelog: none
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 20, 2025
fixes rust-lang#14148 Another case of rust-lang#13077 and rust-lang#8646 changelog: [`needless_option_as_deref`]: fix FP in trait
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.