Optimize out exhortations about being careful#14148
Closed
zookoatleastauthoritycom wants to merge 2 commits intorust-lang:masterfrom
Closed
Optimize out exhortations about being careful#14148zookoatleastauthoritycom wants to merge 2 commits intorust-lang:masterfrom
zookoatleastauthoritycom wants to merge 2 commits intorust-lang:masterfrom
Conversation
added 2 commits
May 12, 2014 15:38
Yes, it is important to be careful, but repeated emphasis about it is probably not helpful — it starts to sound like you came for a tutorial but found a finger-wagging lecture. Even after I removed a few of these comments, there are still several left in the text. That's probably fine! A couple of mentions of how this is dangerous and you ought to be careful may be a good reminder to the reader. Note: this patch doesn't do any reflowing of text, so that you can more easily see the semantic content of this change. I'll follow this up with a patch that reflows the paragraphs that I touched.
using emacs's text-reflowing capabilities
Author
|
Oh, I also did some other English editing work in this branch besides the part that I described in the commit message. |
Contributor
|
Thanks for this! I'm sorry that no-one responded to you for so long. It looks good except for one tiny little nit. |
Member
|
Closing due to inactivity, but feel free to reopen with @huonw's comment! |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 20, 2023
Bump lsp-types
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 20, 2025
fixes rust-lang#14148 Another case of rust-lang#13077 and rust-lang#8646 changelog: [`needless_option_as_deref`]: fix FP in trait
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.