Closed
Conversation
Contributor
|
@erickt: needs a rebase already, looks great though |
Contributor
Author
|
@thestinger: it's (briefly) mergable again. Can you re-review? |
Contributor
|
@erickt: heh, already broken by the last merge |
Contributor
Author
|
@thestinger: Wow, that was more briefly mergable than I expected. Shall we try again? |
Contributor
|
How did you finagle getting rid of the trailing-underscore methods? Has #3429 been fixed? |
Contributor
|
@bstrie: No, it hasn't been fixed. As default methods, they don't encounter the method resolve issue. |
bors
added a commit
that referenced
this pull request
Aug 10, 2013
This PR does a bunch of cleaning up of various APIs. The major one is that it merges `Iterator` and `IteratorUtil`, and renames functions like `transform` into `map`. I also merged `DoubleEndedIterator` and `DoubleEndedIteratorUtil`, as well as I renamed various .consume* functions to .move_iter(). This helps to implement part of #7887.
bors
added a commit
that referenced
this pull request
Aug 10, 2013
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does a bunch of cleaning up of various APIs. The major one is that it merges
IteratorandIteratorUtil, and renames functions liketransformintomap. I also mergedDoubleEndedIteratorandDoubleEndedIteratorUtil, as well as I renamed various .consume* functions to .move_iter(). This helps to implement part of #7887.