Fix incorrect non-exhaustive matching for fixed length vecs#8386
Merged
bors merged 1 commit intorust-lang:masterfrom Aug 11, 2013
Merged
Fix incorrect non-exhaustive matching for fixed length vecs#8386bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Code like this is fixed now:
```
fn foo(p: [u8, ..4]) {
match p {
[a, b, c, d] => {}
};
}
```
Invalid constructors are not reported as errors yet:
```
fn foo(p: [u8, ..4]) {
match p {
[_, _, _] => {} // this should be error
[_, _, _, _, _, .._] => {} // and this
_ => {}
}
}
```
Issue rust-lang#8311 is partially fixed by this commit. Fixed-length arrays in
let statement are not yet allowed:
```
let [a, b, c] = [1, 2, 3]; // still fails
```
Contributor
|
This looks cool! Does it fix it for |
Contributor
Author
|
@huonw no, it is the same: It is a separate issue. |
Contributor
|
Wow, very cool! But if this commit doesn't also fix this for |
Contributor
Author
|
@bstrie updated commit comment. |
bors
added a commit
that referenced
this pull request
Aug 10, 2013
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 10, 2022
Fix ICE in `ptr_arg` fixes: rust-lang#8386 changelog: None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code like this is fixed now:
Invalid constructors are not reported as errors yet:
Issue #8311 is partially fixed: fixed-length vectors in let statement are not yet allowed.