Conversation
jyn514
left a comment
There was a problem hiding this comment.
@rust-lang/cargo what do you think about adding this to cargo as cargo check --doc (and including it in cargo check --all-targets)?
@shepmaster would you be interested in adding this to playground, even without compiling the docs?
cc @rust-lang/rustdoc
|
Sounds like it would be useful to me. |
|
Once this PR is merged, I'll add it to cargo then. |
9500de6 to
a06fd1f
Compare
|
@GuillaumeGomez this isn't very useful unless cargo and playground can use it - do you mind making it insta-stable? Then we can open an FCP and start using it right away. |
|
@jyn514 We can but I was simply thinking about running it on cargo nightly. |
|
Hmm, ok. We can stabilize in a follow-up PR then. @bors r+ |
|
📌 Commit a06fd1f has been approved by |
…laumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#77151 (Add regression test for issue rust-lang#76042) - rust-lang#77996 (Doc change: Remove mention of `fnv` in HashMap) - rust-lang#78463 (Add type to `ConstKind::Placeholder`) - rust-lang#78984 (Rustdoc check option) - rust-lang#78985 (add dropck test for const params) - rust-lang#78996 (add explicit test for const param promotion) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
I've filed #92763 for adding this new |
The ultimate goal behind this option would be to have
rustdoc --checkbeing run when you usecargo checkas a second step.r? @jyn514