Merged
Conversation
Contributor
|
r? @jroesch (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
https://github.com/rust-lang/rust/pull/28697/files?w=1 is a lot nicer to read than the default "Files changed" view. |
Member
Author
|
r? @brson |
Collaborator
|
☔ The latest upstream changes (presumably #28702) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
Author
|
Because the where clause is indented from the left + 4 which is the same indent as the body, without the newline brace it's hard to see where the signature ends and the body begins. Aligning the where clause with the arguments tends to overflow too often. |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 9d34308 has been approved by |
Collaborator
|
🔒 Merge conflict |
Member
Author
|
@bors: r=brson |
Collaborator
|
📌 Commit 869e971 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 5, 2015
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.