store the rustc version in metadata and check it#28702
Merged
bors merged 2 commits intorust-lang:masterfrom Sep 30, 2015
Merged
store the rustc version in metadata and check it#28702bors merged 2 commits intorust-lang:masterfrom
bors merged 2 commits intorust-lang:masterfrom
Conversation
Member
|
@bors: r+ |
Collaborator
|
📌 Commit debc1b9 has been approved by |
Member
|
Is I'm pretty sure there’s a non-trivial population using nightly and these are not compatible between compiles either, are they? |
Contributor
Author
|
CFG_VERSION is what |
Collaborator
|
⌛ Testing commit debc1b9 with merge 804326a... |
Collaborator
|
💔 Test failed - auto-linux-32-opt |
Contributor
|
This prevents ICEs when old crates are used with a new version of rustc. Currently, the linking of crates compiled with different versions of rustc is completely unsupported. Fixes rust-lang#28700
debc1b9 to
9699adc
Compare
Contributor
Author
Collaborator
|
⌛ Testing commit 9699adc with merge ac17bcf... |
Collaborator
|
💔 Test failed - auto-win-msvc-32-opt |
Contributor
Author
|
This compiles locally. Why can't it compile on bors too? |
Contributor
Author
Member
|
@arielb1 it's an intermittent bug, so annoying. Try adding |
Collaborator
Collaborator
This was referenced Sep 30, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents ICEs when old crates are used with a new version of
rustc. Currently, the linking of crates compiled with different
versions of rustc is completely unsupported.
Fixes #28700
r? @nrc