Expand OS X versions referenced in configure message#25198
Merged
bors merged 1 commit intorust-lang:masterfrom May 8, 2015
carols10cents:update-configure-osx
Merged
Expand OS X versions referenced in configure message#25198bors merged 1 commit intorust-lang:masterfrom carols10cents:update-configure-osx
bors merged 1 commit intorust-lang:masterfrom
carols10cents:update-configure-osx
Conversation
10.10 is out, so it's weird to see a message that says you're on 10.9. Change the message to be >=10.9.
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Member
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 8, 2015
… r=alexcrichton Tiny tiny nitpick that I just noticed after getting a new laptop ( 🍺 + 💻 = 👼 ) and thus needing to ./configure anew on Yosemite. It's weird to see a message that says you're on 10.9 if you're on 10.10, in a oh-i-wonder-what-else-is-wrong sort of sense-- easy fix with a `>=` since `gcc --version` on 10.10 with the newest xcode still says it's clang. ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny tiny nitpick that I just noticed after getting a new laptop ( 🍺 + 💻 = 👼 ) and thus needing to ./configure anew on Yosemite.
It's weird to see a message that says you're on 10.9 if you're on 10.10, in a oh-i-wonder-what-else-is-wrong sort of sense-- easy fix with a
>=sincegcc --versionon 10.10 with the newest xcode still says it's clang.❤️