Add long diagnostics for E0046 and E0054#25190
Merged
bors merged 2 commits intorust-lang:masterfrom May 8, 2015
Merged
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Member
There was a problem hiding this comment.
Perhaps this could clarify "It is not allowed to cast a numeric type to a bool"?
Contributor
Author
There was a problem hiding this comment.
From my (admittedly shallow) reading of the code in librustc_typeck/check/cast.rs, it seemed like any casting to bool is disallowed. For example, you can try to cast a bare function to a bool and get E0054.
fn main() {
fn foo() -> u8 { 5 }
let x = foo as bool; // error: cannot cast as `bool`, compare with zero instead [E0054]
}
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc #24407