Skip to content

librustc: hint close matches on accessing nonexisting fields#21187

Merged
bors merged 1 commit intorust-lang:masterfrom
oli-obk:feature/hint_struct_field_access
Jan 22, 2015
Merged

librustc: hint close matches on accessing nonexisting fields#21187
bors merged 1 commit intorust-lang:masterfrom
oli-obk:feature/hint_struct_field_access

Conversation

@oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jan 15, 2015

rebase and fix of #19267

@rust-highfive
Copy link
Contributor

rust-highfive commented Jan 15, 2015

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@oli-obk oli-obk force-pushed the feature/hint_struct_field_access branch 2 times, most recently from 59241c8 to 9cd90f7 Compare January 15, 2015 12:01
alexcrichton
alexcrichton reviewed Jan 18, 2015
View reviewed changes
src/librustc_typeck/check/mod.rs
Copy link
Member

@alexcrichton alexcrichton Jan 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test for this error message as well?

Copy link
Contributor Author

@oli-obk oli-obk Jan 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, allthough the test is not (yet) useful since it's ignored: #21195

@oli-obk oli-obk force-pushed the feature/hint_struct_field_access branch 3 times, most recently from 9f085cc to c8d68a7 Compare January 19, 2015 12:51
@oli-obk
Copy link
Contributor Author

oli-obk commented Jan 19, 2015

rebased on master, added test and changed number of help messages to one. local make check-stage1 passes, make check is running right now

@oli-obk
Copy link
Contributor Author

oli-obk commented Jan 19, 2015

make check passed

@alexcrichton
Copy link
Member

alexcrichton commented Jan 19, 2015

Thanks! Could you squash the commits together as well?

@oli-obk oli-obk force-pushed the feature/hint_struct_field_access branch from c8d68a7 to b24da87 Compare January 19, 2015 20:42
@oli-obk
Copy link
Contributor Author

oli-obk commented Jan 19, 2015

i just left them there for easier reading.
squashed and rebased

@alexcrichton
Copy link
Member

alexcrichton commented Jan 19, 2015

@bors: r+ b24da87

@bors
Copy link
Collaborator

bors commented Jan 20, 2015

⌛ Testing commit b24da87 with merge b63cc5c...

@bors
Copy link
Collaborator

bors commented Jan 20, 2015

💔 Test failed - auto-mac-64-opt

@oli-obk oli-obk force-pushed the feature/hint_struct_field_access branch from b24da87 to 09d9924 Compare January 20, 2015 09:59
@oli-obk
Copy link
Contributor Author

oli-obk commented Jan 20, 2015

sorry about that. fixed, rebased and make check ran through

@alexcrichton
Copy link
Member

alexcrichton commented Jan 20, 2015

@bors: r+ 09d9924

bors added a commit that referenced this pull request Jan 22, 2015
@bors
Auto merge of #21187 - oli-obk:feature/hint_struct_field_access, r=al…
b7930d9 
…excrichton

rebase and fix of #19267
@bors
Copy link
Collaborator

bors commented Jan 22, 2015

⌛ Testing commit 09d9924 with merge b7930d9...

@bors
Copy link
Collaborator

bors commented Jan 22, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt

@bors bors merged commit 09d9924 into rust-lang:master Jan 22, 2015
@oli-obk oli-obk deleted the feature/hint_struct_field_access branch January 23, 2015 09:25
lnicola pushed a commit to lnicola/rust that referenced this pull request Dec 15, 2025
@ChayimFriedman2
Merge pull request rust-lang#21187 from nicolas-guichard/push-orysqtu…
120be9b 
…lnxww

Include operator overload occurrences in SCIP index
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichton alexcrichton

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oli-obk @rust-highfive @alexcrichton @bors