librustc: hint close matches on accessing nonexisting fields#19267
Closed
oli-obk wants to merge 1 commit intorust-lang:masterfrom
Closed
librustc: hint close matches on accessing nonexisting fields#19267oli-obk wants to merge 1 commit intorust-lang:masterfrom
oli-obk wants to merge 1 commit intorust-lang:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Our style is to not add any whitespace for alignment.
Contributor
|
Could you add some tests for this? Just a few cases in compile-fail that the messages get emitted. |
d179dc0 to
5d1b223
Compare
Contributor
|
@oli-obk have you made all your changes? (github doesn't notify us when you just add commits, you need to ping someone when you're ready). Regardless, needs a rebase. |
Contributor
Author
|
not yet, as i need to rewrite some of the error reporting code, to prevent hinting field names of fields that are actually set |
Contributor
|
closing for inactivity. @oli-obk let us know when you get back to this. It needs rebase so probably a new PR would be just fine. |
bors
added a commit
that referenced
this pull request
Jan 22, 2015
…excrichton rebase and fix of #19267
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now shows
same help message for accessing fields.
can't do it for functions, as they aren't iteratable. Only exact lookups are possible there.