Skip to content

Optimize ArrayChunks::try_rfold with DoubleEndedIterator::next_chunk_back#158704

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
asder8215:optimize_array_chunks
Jul 5, 2026
Merged

Optimize ArrayChunks::try_rfold with DoubleEndedIterator::next_chunk_back#158704
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
asder8215:optimize_array_chunks

Conversation

@asder8215

@asder8215 asder8215 commented Jul 2, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Since DoubleEndedIterator::next_chunk_back got merged in #156737, we can apply this method to optimize ArrayChunk::try_rfold.

I added @vinDelphini as a co-author because he was the one who originally made this change in his original PR on introducing DoubleEndedIterator::next_chunk_back.

@asder8215 @vinDelphini
Optimize ArrayChunks::try_rfold with DoubleEndedIterator::next_chunk_…
841041c 
…back

Co-authored-by: Vin <betadelphini.py@gmail.com>
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 2, 2026
@rustbot

rustbot commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

r? @aapoalas

rustbot has assigned @aapoalas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 12 candidates
  • Random selection from 7 candidates

This was referenced Jul 2, 2026
Closed
Closed
aapoalas
aapoalas approved these changes Jul 3, 2026
View reviewed changes

@aapoalas aapoalas left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to get this simplified <3

View changes since this review

@aapoalas

aapoalas commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

@bors r+

@rust-bors

rust-bors Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 841041c has been approved by aapoalas

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 10. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 3, 2026
@jhpratt
Rollup merge of rust-lang#158704 - asder8215:optimize_array_chunks, r…
1d761ce 
…=aapoalas

Optimize `ArrayChunks::try_rfold` with `DoubleEndedIterator::next_chunk_back`

Since `DoubleEndedIterator::next_chunk_back` got merged in rust-lang#156737, we can apply this method to optimize `ArrayChunk::try_rfold`.

I added @vinDelphini as a co-author because he was the one who originally made this change in his original PR on introducing [`DoubleEndedIterator::next_chunk_back`](rust-lang#151668).
@jhpratt jhpratt mentioned this pull request Jul 3, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Jul 5, 2026
@bors
Auto merge of #158753 - jhpratt:rollup-nhJHVUD, r=jhpratt
02b8c2e 
Rollup of 18 pull requests

Successful merges:

 - #158692 (Add release notes for 1.96.1)
 - #134021 (Implement `IntoIterator` for `[&[mut]] Box<[T; N], A>`)
 - #152860 (Port the `without_debuginfo` test from `backtrace-rs` to the testsuite)
 - #155932 (MIR Call terminator: evaluate destination place before arguments)
 - #156777 (Add -Zautodiff_post_passes flag to limit which llvm passes to run after enzyme to make autodiff tests more robust)
 - #157151 (JSON target specs: remove 'x86-softfloat' compatibility alias)
 - #157835 (expand free alias types in the auto-trait orphan check)
 - #158377 (add `-Zforce-intrinsic-fallback` flag)
 - #158434 (delegation: refactor AST -> HIR lowering)
 - #158552 (make some tidy errors around python easier to understand)
 - #158624 (borrowck: Introduce BlameConstraint::to_obligation_cause_from_path())
 - #158704 (Optimize `ArrayChunks::try_rfold` with `DoubleEndedIterator::next_chunk_back`)
 - #158711 (library: Comment on libtest's dicey internal soundness)
 - #158539 (Move `SizeHint` and `IoHandle` to `core::io`)
 - #158659 (refactor the normalization in `coerce_shared_info`)
 - #158689 (resolver: don't use `Finalize` when resolving visibilities during AST expansion)
 - #158698 (Update TypeVisitable implementation)
 - #158706 (Tweaks to MIR building scope API)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 5, 2026
@JonathanBrouwer
Rollup merge of rust-lang#158704 - asder8215:optimize_array_chunks, r…
afbae61 
…=aapoalas

Optimize `ArrayChunks::try_rfold` with `DoubleEndedIterator::next_chunk_back`

Since `DoubleEndedIterator::next_chunk_back` got merged in rust-lang#156737, we can apply this method to optimize `ArrayChunk::try_rfold`.

I added @vinDelphini as a co-author because he was the one who originally made this change in his original PR on introducing [`DoubleEndedIterator::next_chunk_back`](rust-lang#151668).
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jul 5, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Jul 5, 2026
@bors
Auto merge of #158798 - JonathanBrouwer:rollup-DS89hW9, r=JonathanBro…
b7c8670 
…uwer

Rollup of 20 pull requests

Successful merges:

 - #158692 (Add release notes for 1.96.1)
 - #134021 (Implement `IntoIterator` for `[&[mut]] Box<[T; N], A>`)
 - #155932 (MIR Call terminator: evaluate destination place before arguments)
 - #155989 (Update `transmute_copy` to ub_checks and `?Sized`)
 - #156777 (Add -Zautodiff_post_passes flag to limit which llvm passes to run after enzyme to make autodiff tests more robust)
 - #157151 (JSON target specs: remove 'x86-softfloat' compatibility alias)
 - #157835 (expand free alias types in the auto-trait orphan check)
 - #157857 (Stabilize `#[my_macro] mod foo;` (part of `proc_macro_hygiene`))
 - #158377 (add `-Zforce-intrinsic-fallback` flag)
 - #158434 (delegation: refactor AST -> HIR lowering)
 - #158552 (make some tidy errors around python easier to understand)
 - #158624 (borrowck: Introduce BlameConstraint::to_obligation_cause_from_path())
 - #158704 (Optimize `ArrayChunks::try_rfold` with `DoubleEndedIterator::next_chunk_back`)
 - #158711 (library: Comment on libtest's dicey internal soundness)
 - #158751 (rustdoc: Fix crash when trying to inline foreign item which cannot have attributes)
 - #158539 (Move `SizeHint` and `IoHandle` to `core::io`)
 - #158659 (refactor the normalization in `coerce_shared_info`)
 - #158689 (resolver: don't use `Finalize` when resolving visibilities during AST expansion)
 - #158698 (Update TypeVisitable implementation)
 - #158706 (Tweaks to MIR building scope API)
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jul 5, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Jul 5, 2026
@bors
Auto merge of #158811 - JonathanBrouwer:rollup-Rzb4mH7, r=JonathanBro…
3659db0 
…uwer

Rollup of 19 pull requests

Successful merges:

 - #158692 (Add release notes for 1.96.1)
 - #134021 (Implement `IntoIterator` for `[&[mut]] Box<[T; N], A>`)
 - #155932 (MIR Call terminator: evaluate destination place before arguments)
 - #155989 (Update `transmute_copy` to ub_checks and `?Sized`)
 - #156777 (Add -Zautodiff_post_passes flag to limit which llvm passes to run after enzyme to make autodiff tests more robust)
 - #157151 (JSON target specs: remove 'x86-softfloat' compatibility alias)
 - #157835 (expand free alias types in the auto-trait orphan check)
 - #157857 (Stabilize `#[my_macro] mod foo;` (part of `proc_macro_hygiene`))
 - #158434 (delegation: refactor AST -> HIR lowering)
 - #158552 (make some tidy errors around python easier to understand)
 - #158624 (borrowck: Introduce BlameConstraint::to_obligation_cause_from_path())
 - #158704 (Optimize `ArrayChunks::try_rfold` with `DoubleEndedIterator::next_chunk_back`)
 - #158711 (library: Comment on libtest's dicey internal soundness)
 - #158751 (rustdoc: Fix crash when trying to inline foreign item which cannot have attributes)
 - #158539 (Move `SizeHint` and `IoHandle` to `core::io`)
 - #158659 (refactor the normalization in `coerce_shared_info`)
 - #158689 (resolver: don't use `Finalize` when resolving visibilities during AST expansion)
 - #158698 (Update TypeVisitable implementation)
 - #158706 (Tweaks to MIR building scope API)
@rust-bors rust-bors Bot merged commit 441314a into rust-lang:main Jul 5, 2026
13 checks passed
@rustbot rustbot added this to the 1.98.0 milestone Jul 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aapoalas aapoalas aapoalas approved these changes

Assignees

@aapoalas aapoalas

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.98.0

Development

Successfully merging this pull request may close these issues.

3 participants

@asder8215 @rustbot @aapoalas