Port the `without_debuginfo` test from `backtrace-rs` to the testsuite by JayanAXHF · Pull Request #152860 · rust-lang/rust

JayanAXHF · 2026-02-19T18:11:13Z

Ports over the without_debuginfo from backtrace-rs to the testsuite.
Caveat: I had to create a nightly feature backtrace_internals_accessors to access the internals of std::backtrace::Backtrace and std::backtrace::BacktraceFrames. It is not on the stabilisation track, since it doesn't have an ACP.

r? @workingjubilee

rustbot · 2026-02-19T18:11:18Z

workingjubilee is currently at their maximum review capacity.
They may take a while to respond.

rustbot · 2026-02-19T18:48:02Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

rustbot · 2026-02-19T18:58:53Z

Some changes occurred in src/tools/cargo

cc @ehuss

JayanAXHF · 2026-02-19T20:10:05Z

@workingjubilee This CI failure seems unrelated to the test? Is this a known issue/regression?

workingjubilee · 2026-02-19T21:47:41Z

that's weird.

tests/ui/README.md

workingjubilee · 2026-02-19T21:52:10Z

tests/ui/no_debuginfo/all_frames_have_symbols.rs

+fn main() {
+    let mut missing_symbols = 0;
+    let mut has_symbols = 0;
+    let btrace = backtrace::Backtrace::force_capture();
+    let frames = btrace.frames();
+    for frame in frames {
+        let mut any = false;
+        for sym in frame.symbols() {
+            if sym.name().is_some() {
+                any = true;
+                break;
+            }
+        }
+        if any {
+            has_symbols += 1;
+        } else if !frame.ip().is_null() {
+            missing_symbols += 1;
+        }
+    }
+
+    // FIXME(#346) currently on MinGW we can't symbolize kernel32.dll and other
+    // system libraries, which means we miss the last few symbols.
+    if cfg!(windows) && cfg!(target_env = "gnu") {
+        assert!(missing_symbols < has_symbols && has_symbols > 4);
+    } else {
+        assert_eq!(missing_symbols, 0);
+    }


This isn't a known problem, so we may need to determine how many frames are missing symbols and it may be aarch64-unknown-linux-gnu specific.

Well it doesn't occur on my arm m2 mac so maybe it's specific? Might wanna check windows too to determine if it's x86

Oops I misread the target. Do you mind if I rerun the CI for x86 Linux to try to repro the problem?

@workingjubilee I added some debug info to try to find the frame with the missing info. Also could #152870 be relevant to this?

JayanAXHF · 2026-02-20T11:10:13Z

--- stderr -------------------------------
missing symbol for frame 6: []
Full erroneous backtrace: Backtrace [
    { fn: "<std::backtrace::Backtrace>::create" },
    { fn: "all_frames_have_symbols::main" },
    { fn: "std::sys::backtrace::__rust_begin_short_backtrace::<fn(), ()>" },
    { fn: "std::rt::lang_start::<()>::{closure#0}" },
    { fn: "std::rt::lang_start_internal" },
    { fn: "main" },
    { fn: "__libc_start_main" },
    { fn: "_start" },
]
thread 'main' (117654) panicked at /checkout/tests/ui/no_debuginfo/all_frames_have_symbols.rs:37:9:
assertion `left == right` failed
  left: 1
 right: 0
stack backtrace:
   0: __rustc::rust_begin_unwind
   1: core::panicking::panic_fmt
   2: core::panicking::assert_failed_inner
   3: core::panicking::assert_failed::<i32, i32>
   4: all_frames_have_symbols::main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
------------------------------------------

This is the relevant debug log. Apparently the __libc_start_main doesn't have a symbol

JayanAXHF · 2026-03-05T15:14:04Z

@workingjubilee do you have any time to look at this soon?

JayanAXHF added A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. A-backtrace Area: Backtraces labels Feb 19, 2026

rustbot assigned workingjubilee Feb 19, 2026

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 19, 2026

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 19, 2026

This comment has been minimized.

Sign in to view

rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 19, 2026

JayanAXHF added 3 commits February 20, 2026 00:21

feat: add a nightly feature for Backtrace Frame access

ed55daa

test: port no_debuginfo to the testsuite

e255ee5

chore: update tests/ui/README.md

a7b8152

JayanAXHF force-pushed the tests/porting-no-debuginfo branch from 6f4d672 to a7b8152 Compare February 19, 2026 18:58

This comment has been minimized.

Sign in to view

rustbot removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. has-merge-commits PR has merge commits, merge with caution. labels Feb 19, 2026

JayanAXHF force-pushed the tests/porting-no-debuginfo branch from 2afe45b to e93dd0f Compare February 19, 2026 19:11

fixup! chore: update tests/ui/README.md

2ee2332

JayanAXHF force-pushed the tests/porting-no-debuginfo branch from e93dd0f to 2ee2332 Compare February 19, 2026 19:12

This comment has been minimized.

Sign in to view

workingjubilee reviewed Feb 19, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

test: add debug info for the test to find the missing symbols

f245f10

JayanAXHF force-pushed the tests/porting-no-debuginfo branch from 2f11378 to f245f10 Compare February 20, 2026 10:26

This comment has been minimized.

Sign in to view

fixup chore: revert formatting changes

a2e9dad

This comment has been minimized.

Sign in to view

fix: add exception for aarch64-unknown-linux-gnu

a54b642

JayanAXHF force-pushed the tests/porting-no-debuginfo branch from 60edd1c to a54b642 Compare February 24, 2026 11:15

JayanAXHF requested a review from workingjubilee March 8, 2026 04:20

Uh oh!

Conversation

JayanAXHF commented Feb 19, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Feb 19, 2026

Uh oh!

This comment has been minimized.

rustbot commented Feb 19, 2026

Uh oh!

This comment has been minimized.

rustbot commented Feb 19, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

JayanAXHF commented Feb 19, 2026

Uh oh!

workingjubilee commented Feb 19, 2026

Uh oh!

Uh oh!

workingjubilee Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

JayanAXHF Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

workingjubilee Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

JayanAXHF Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

JayanAXHF Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

JayanAXHF commented Feb 20, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

JayanAXHF commented Mar 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JayanAXHF commented Feb 19, 2026 •

edited by rustbot

Loading