Skip to content

Move AttributeTemplate from rustc_feature to rustc_attr_parsing#157624

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
ariagivens:move-attribute-template
Jun 9, 2026
Merged

Move AttributeTemplate from rustc_feature to rustc_attr_parsing#157624
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
ariagivens:move-attribute-template

Conversation

@ariagivens

Copy link
Copy Markdown
Contributor

Refactor as discussed on zulip.

r? @JonathanBrouwer

@rustbot

rustbot commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred to diagnostic attributes.

cc @mejrs

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 8, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Contributor

@bors r+ rollup
Thanks!

@rust-bors

rust-bors Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 2258119 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2026
rust-bors Bot pushed a commit that referenced this pull request Jun 9, 2026
Rollup of 5 pull requests

Successful merges:

 - #154543 (Fix deref field pattern suggestions and improve error messages)
 - #157476 (Adopt to LLVM 23 CfiFunctionIndex change)
 - #157542 (Reject `#[repr(packed)]` on `#[pin_v2]` types)
 - #157603 (Fixed Doc Comment Typo in Linewritershim)
 - #157624 (Move AttributeTemplate from rustc_feature to rustc_attr_parsing)
@rust-bors rust-bors Bot merged commit ac38925 into rust-lang:main Jun 9, 2026
12 checks passed
rust-timer added a commit that referenced this pull request Jun 9, 2026
Rollup merge of #157624 - ariagivens:move-attribute-template, r=JonathanBrouwer

Move AttributeTemplate from rustc_feature to rustc_attr_parsing

Refactor as discussed on zulip.

r? @JonathanBrouwer
@rustbot rustbot added this to the 1.98.0 milestone Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants