Skip to content

Fixed Doc Comment Typo in Linewritershim#157603

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
innin-jam:fix-doc-comment-typo-in-std
Jun 9, 2026
Merged

Fixed Doc Comment Typo in Linewritershim#157603
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
innin-jam:fix-doc-comment-typo-in-std

Conversation

@innin-jam

Copy link
Copy Markdown
Contributor

The doc comment of the flush_if_completed_line
function spelt 'if' as 'iff'.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 8, 2026
@rustbot

rustbot commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jhpratt (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue
Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 11 candidates
  • Random selection from Mark-Simulacrum, aapoalas, clarfonthey, jhpratt

@jhpratt

jhpratt commented Jun 8, 2026

Copy link
Copy Markdown
Member

Can you actually change this to "if and only if"? I'm fairly certain the current spelling was deliberate (as a mathematical shorthand). You'll almost certainly need to format the code to ensure the line is wrapped properly.

Changed the doc comment of the
`flush_if_completed_line` function to use explicit
'if and only if' instead of it's shorthand 'iff'.
@innin-jam innin-jam force-pushed the fix-doc-comment-typo-in-std branch from 14b5b2a to d412ac1 Compare June 8, 2026 10:59
@jhpratt

jhpratt commented Jun 8, 2026

Copy link
Copy Markdown
Member

Thanks!

@bors r+ rollup

@rust-bors

rust-bors Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

📌 Commit d412ac1 has been approved by jhpratt

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2026
rust-bors Bot pushed a commit that referenced this pull request Jun 9, 2026
Rollup of 5 pull requests

Successful merges:

 - #154543 (Fix deref field pattern suggestions and improve error messages)
 - #157476 (Adopt to LLVM 23 CfiFunctionIndex change)
 - #157542 (Reject `#[repr(packed)]` on `#[pin_v2]` types)
 - #157603 (Fixed Doc Comment Typo in Linewritershim)
 - #157624 (Move AttributeTemplate from rustc_feature to rustc_attr_parsing)
@rust-bors rust-bors Bot merged commit 03c9171 into rust-lang:main Jun 9, 2026
12 checks passed
@rustbot rustbot added this to the 1.98.0 milestone Jun 9, 2026
rust-timer added a commit that referenced this pull request Jun 9, 2026
Rollup merge of #157603 - innin-jam:fix-doc-comment-typo-in-std, r=jhpratt

Fixed Doc Comment Typo in Linewritershim

The doc comment of the `flush_if_completed_line`
function spelt 'if' as 'iff'.
@innin-jam innin-jam deleted the fix-doc-comment-typo-in-std branch June 9, 2026 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants