Document wasi-sdk minimum versions for WASI targets#156258
Document wasi-sdk minimum versions for WASI targets#156258rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
|
Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb |
|
r? @folkertdev rustbot has assigned @folkertdev. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
6a780ee to
23a8248
Compare
This comment has been minimized.
This comment has been minimized.
This commit updates the documentation for WASI targets in the rustc book to mention a minimum version of wasi-sdk that's required. Closes 155971
23a8248 to
aadf600
Compare
There was a problem hiding this comment.
Thanks. Even if these baselines are in theory too aggressive, it's at least more correct than the currently stated 22.
(Can still tweak later if needed.)
r? me @bors r+ rollup
| To build this target first acquire a copy of | ||
| [`wasi-sdk`](https://github.com/WebAssembly/wasi-sdk/). At this time version 22 | ||
| is the minimum needed. | ||
| To build this target first acquire a copy of [`wasi-sdk`]. At this time version |
There was a problem hiding this comment.
Question (non-blocking): for the wasipN targets, do we just tend to want to use the latest released wasi-sdk as target baseline? Since looking at wasi-sdk's releases, 33 was just out last week, right?
There was a problem hiding this comment.
Given the relative age of the wasip1 and WASI and wasi-libc/wasi-sdk, personally I would say, yeah, Rust should be tracking the latest. This is something that'll highly likely change over time, but for the time being the goal is to have upgrades in wasi-sdk be relatively easy and to continue to have the freedom to push things forward while we still can on the WASI side. Eventually I think there'll be strong reasons to be more conservative, but my hope is we can postpone that for awhile...
…ieyouxu Document wasi-sdk minimum versions for WASI targets This commit updates the documentation for WASI targets in the rustc book to mention a minimum version of wasi-sdk that's required. Closes rust-lang#155971
…ieyouxu Document wasi-sdk minimum versions for WASI targets This commit updates the documentation for WASI targets in the rustc book to mention a minimum version of wasi-sdk that's required. Closes rust-lang#155971
…ieyouxu Document wasi-sdk minimum versions for WASI targets This commit updates the documentation for WASI targets in the rustc book to mention a minimum version of wasi-sdk that's required. Closes rust-lang#155971
Rollup of 14 pull requests Successful merges: - #146273 (lint ImproperCTypes: refactor linting architecture (part 2)) - #149509 (Lint unused pub items in binary crates) - #156173 (Fewer global node_id_to_def_id lookups) - #156177 (windows/time: avoid being too close to 0) - #155961 (Deny warnings in the test for crates that are available on stable) - #155981 (Use special DefIds for aliases) - #156109 (Migrate libraries from ptr::slice_from_raw_parts to .cast_slice) - #156130 (Fold/visit tweaks) - #156131 (Metadata macro/query cleanups) - #156202 (llvm: Use correct type for splat mask) - #156227 (Add Trusty OS to the generic error implementation.) - #156237 (compiletest: prevent directives from having multiple revisions) - #156241 (Move tests coercion) - #156258 (Document wasi-sdk minimum versions for WASI targets)
Rollup of 12 pull requests Successful merges: - #156173 (Fewer global node_id_to_def_id lookups) - #156177 (windows/time: avoid being too close to 0) - #155961 (Deny warnings in the test for crates that are available on stable) - #155981 (Use special DefIds for aliases) - #156130 (Fold/visit tweaks) - #156131 (Metadata macro/query cleanups) - #156202 (llvm: Use correct type for splat mask) - #156223 (Refactor `Type::size` field to `TypeId::size` method for `type_info`) - #156227 (Add Trusty OS to the generic error implementation.) - #156237 (compiletest: prevent directives from having multiple revisions) - #156241 (Move tests coercion) - #156258 (Document wasi-sdk minimum versions for WASI targets)
Rollup of 12 pull requests Successful merges: - #156173 (Fewer global node_id_to_def_id lookups) - #156177 (windows/time: avoid being too close to 0) - #155961 (Deny warnings in the test for crates that are available on stable) - #155981 (Use special DefIds for aliases) - #156130 (Fold/visit tweaks) - #156131 (Metadata macro/query cleanups) - #156202 (llvm: Use correct type for splat mask) - #156223 (Refactor `Type::size` field to `TypeId::size` method for `type_info`) - #156227 (Add Trusty OS to the generic error implementation.) - #156237 (compiletest: prevent directives from having multiple revisions) - #156241 (Move tests coercion) - #156258 (Document wasi-sdk minimum versions for WASI targets)
This commit updates the documentation for WASI targets in the rustc book to mention a minimum version of wasi-sdk that's required.
Closes #155971