windows/time: avoid being too close to 0#156177
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom May 7, 2026
Merged
windows/time: avoid being too close to 0#156177rust-bors[bot] merged 1 commit intorust-lang:mainfrom
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
r? @jhpratt rustbot has assigned @jhpratt. Use Why was this reviewer chosen?The reviewer was selected based on:
|
99d0aef to
a07a3b1
Compare
tbu-
reviewed
May 6, 2026
| // We can add an arbitrary offset to shift the epoch of this clock. We do that to avoid | ||
| // being too close to 0 which would lead to underflow when computing times in the past. Also | ||
| // see <https://github.com/rust-lang/rust/issues/156142>. | ||
| let instant_nsec = instant_nsec + (u64::MAX / 4); |
Contributor
There was a problem hiding this comment.
Would be nicer to use a signed type for storing the nanoseconds, otherwise we have this useless addition on every Instant::now.
Using a signed type would make this essentially free.
Member
Author
There was a problem hiding this comment.
We use Duration so using anything singed would be a major refactor.
Member
There was a problem hiding this comment.
We would need to make something more or less equivalent to a SignedDuration type if we want to share it between different implementations of Instant. It's a shame we can't just wrap the value of perf_counter::now() but Instant is required to have nanosecond permissions so that's right out.
Member
|
I'll admit I don't exactly love this but it addresses the issue for now so... @bors r+ |
Contributor
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
May 7, 2026
…isDenton windows/time: avoid being too close to 0 Fixes rust-lang#156142 (but only for Windows -- should we still track it for non-tier-1-platforms?)
rust-bors Bot
pushed a commit
that referenced
this pull request
May 7, 2026
Rollup of 14 pull requests Successful merges: - #146273 (lint ImproperCTypes: refactor linting architecture (part 2)) - #149509 (Lint unused pub items in binary crates) - #156173 (Fewer global node_id_to_def_id lookups) - #156177 (windows/time: avoid being too close to 0) - #155961 (Deny warnings in the test for crates that are available on stable) - #155981 (Use special DefIds for aliases) - #156109 (Migrate libraries from ptr::slice_from_raw_parts to .cast_slice) - #156130 (Fold/visit tweaks) - #156131 (Metadata macro/query cleanups) - #156202 (llvm: Use correct type for splat mask) - #156227 (Add Trusty OS to the generic error implementation.) - #156237 (compiletest: prevent directives from having multiple revisions) - #156241 (Move tests coercion) - #156258 (Document wasi-sdk minimum versions for WASI targets)
rust-bors Bot
pushed a commit
that referenced
this pull request
May 7, 2026
Rollup of 12 pull requests Successful merges: - #156173 (Fewer global node_id_to_def_id lookups) - #156177 (windows/time: avoid being too close to 0) - #155961 (Deny warnings in the test for crates that are available on stable) - #155981 (Use special DefIds for aliases) - #156130 (Fold/visit tweaks) - #156131 (Metadata macro/query cleanups) - #156202 (llvm: Use correct type for splat mask) - #156223 (Refactor `Type::size` field to `TypeId::size` method for `type_info`) - #156227 (Add Trusty OS to the generic error implementation.) - #156237 (compiletest: prevent directives from having multiple revisions) - #156241 (Move tests coercion) - #156258 (Document wasi-sdk minimum versions for WASI targets)
rust-bors Bot
pushed a commit
that referenced
this pull request
May 7, 2026
Rollup of 12 pull requests Successful merges: - #156173 (Fewer global node_id_to_def_id lookups) - #156177 (windows/time: avoid being too close to 0) - #155961 (Deny warnings in the test for crates that are available on stable) - #155981 (Use special DefIds for aliases) - #156130 (Fold/visit tweaks) - #156131 (Metadata macro/query cleanups) - #156202 (llvm: Use correct type for splat mask) - #156223 (Refactor `Type::size` field to `TypeId::size` method for `type_info`) - #156227 (Add Trusty OS to the generic error implementation.) - #156237 (compiletest: prevent directives from having multiple revisions) - #156241 (Move tests coercion) - #156258 (Document wasi-sdk minimum versions for WASI targets)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #156142 (but only for Windows -- should we still track it for non-tier-1-platforms?)