Skip to content

Rollup of 2 pull requests#156117

Closed
JonathanBrouwer wants to merge 5 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-IcBHYEl
Closed

Rollup of 2 pull requests#156117
JonathanBrouwer wants to merge 5 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-IcBHYEl

Conversation

@JonathanBrouwer
Copy link
Copy Markdown
Contributor

Successful merges:

r? @ghost

Create a similar rollup

folkertdev and others added 5 commits May 1, 2026 13:20
Just gating `...` is insufficient because we make the types available
everywhere, and you could still define and export functions that used
va_arg for targets where we don't want to stably support it.
…-test, r=joshtriplett

c-variadic: gate `va_arg` on `c_variadic_experimental_arch`

tracking issue: rust-lang#44930

Just gating `...` is insufficient because we make the types available everywhere, and you could still define and export functions that used va_arg for targets where we don't want to stably support it.

r? joshtriplett
…lice-vec, r=JonathanBrouwer

Move tests array slice vec

r? @Kivooeo
Hi, some tests that belong in the  array-slice-vec folder
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label May 3, 2026
@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 3, 2026
@JonathanBrouwer
Copy link
Copy Markdown
Contributor Author

@bors r+ rollup=never p=5

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 3, 2026

📌 Commit 93a1109 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 3, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request May 3, 2026
…uwer

Rollup of 2 pull requests

Successful merges:

 - #156043 (c-variadic: gate `va_arg` on `c_variadic_experimental_arch`)
 - #156044 (Move tests array slice vec)
@rust-log-analyzer
Copy link
Copy Markdown
Collaborator

The job x86_64-gnu-nopt failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

---- [assembly] tests/assembly-llvm/c-variadic/avr.rs#AVR stdout ----
------FileCheck stdout------------------------------

------FileCheck stderr------------------------------
/checkout/tests/assembly-llvm/c-variadic/avr.rs:47:15: error: AVR-NEXT: is not on the line after the previous match
 // AVR-NEXT: ld r24, Z
              ^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/assembly-llvm/c-variadic/avr.AVR/avr.s:25:2: note: 'next' match was here
 ld r24, Z
 ^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/assembly-llvm/c-variadic/avr.AVR/avr.s:22:15: note: previous match ended here
 movw r30, r24
              ^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/assembly-llvm/c-variadic/avr.AVR/avr.s:23:1: note: non-matching line after previous match is here
 std Y+4, r31
^
/checkout/tests/assembly-llvm/c-variadic/avr.rs:73:10: error: AVR: expected string not found in input
 // AVR: push r14
         ^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/assembly-llvm/c-variadic/avr.AVR/avr.s:73:25: note: scanning from here
 .section .text.read_f64,"ax",@progbits
                        ^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/assembly-llvm/c-variadic/avr.AVR/avr.s:78:2: note: possible intended match here
 push r28
 ^
/checkout/tests/assembly-llvm/c-variadic/avr.rs:125:15: error: AVR-NEXT: is not on the line after the previous match
 // AVR-NEXT: ld r24, Z
              ^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/assembly-llvm/c-variadic/avr.AVR/avr.s:195:2: note: 'next' match was here
 ld r24, Z
 ^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/assembly-llvm/c-variadic/avr.AVR/avr.s:192:15: note: previous match ended here
 movw r30, r24
              ^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/assembly-llvm/c-variadic/avr.AVR/avr.s:193:1: note: non-matching line after previous match is here
 std Y+2, r31
^
/checkout/tests/assembly-llvm/c-variadic/avr.rs:143:15: error: AVR-NEXT: is not on the line after the previous match
 // AVR-NEXT: ld r24, Z
              ^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/assembly-llvm/c-variadic/avr.AVR/avr.s:242:2: note: 'next' match was here
 ld r24, Z
 ^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/assembly-llvm/c-variadic/avr.AVR/avr.s:239:15: note: previous match ended here
 movw r30, r24
              ^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/assembly-llvm/c-variadic/avr.AVR/avr.s:240:1: note: non-matching line after previous match is here
 std Y+4, r31
^
/checkout/tests/assembly-llvm/c-variadic/avr.rs:169:10: error: AVR: expected string not found in input
 // AVR: push r14
         ^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/assembly-llvm/c-variadic/avr.AVR/avr.s:290:25: note: scanning from here
 .section .text.read_i64,"ax",@progbits
                        ^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/assembly-llvm/c-variadic/avr.AVR/avr.s:295:2: note: possible intended match here
 push r28
 ^

Input file: /checkout/obj/build/x86_64-unknown-linux-gnu/test/assembly-llvm/c-variadic/avr.AVR/avr.s
Check file: /checkout/tests/assembly-llvm/c-variadic/avr.rs

-dump-input=help explains the following input dump.

Input was:
<<<<<<
             1: __tmp_reg__ = 0 
             2: __zero_reg__ = 1 
             3: __SREG__ = 63 
             4: __SP_H__ = 62 
             5: __SP_L__ = 61 
             6:  .file "avr.4b277fe43e6c3e4c-cgu.0" 
             7:  .section .text.read_f32,"ax",@progbits 
             8:  .globl read_f32 
             9:  .p2align 1 
            10:  .type read_f32,@function 
            11: read_f32: 
            12:  push r28 
            13:  push r29 
            14:  in r28, 61 
            15:  in r29, 62 
            16:  sbiw r28, 10 
            17:  in r0, 63 
            18:  cli 
            19:  out 62, r29 
            20:  out 63, r0 
            21:  out 61, r28 
            22:  movw r30, r24 
            23:  std Y+4, r31 
            24:  std Y+3, r30 
            25:  ld r24, Z 
next:47          !~~~~~~~~  error: match on wrong line
            26:  ldd r25, Z+1 
            27:  ldd r30, Y+3 
            28:  ldd r31, Y+4 
            29:  std Y+2, r25 
            30:  std Y+1, r24 
            31:  adiw r24, 2 
            32:  std Z+1, r25 
            33:  st Z, r24 
            34:  ldd r30, Y+1 
            35:  ldd r31, Y+2 
            36:  ld r24, Z 
            37:  ldd r25, Z+1 
            38:  ldd r30, Y+3 
            39:  ldd r31, Y+4 
            40:  ld r26, Z 
            41:  ldd r27, Z+1 
            42:  ldd r30, Y+3 
            43:  ldd r31, Y+4 
            44:  std Y+6, r27 
            45:  std Y+5, r26 
            46:  adiw r26, 2 
            47:  std Z+1, r27 
            48:  st Z, r26 
            49:  ldd r30, Y+5 
            50:  ldd r31, Y+6 
            51:  ld r18, Z 
            52:  ldd r19, Z+1 
            53:  std Y+10, r19 
            54:  std Y+9, r18 
            55:  std Y+8, r25 
            56:  std Y+7, r24 
            57:  ldd r22, Y+7 
            58:  ldd r23, Y+8 
            59:  ldd r24, Y+9 
            60:  ldd r25, Y+10 
            61:  adiw r28, 10 
            62:  in r0, 63 
            63:  cli 
            64:  out 62, r29 
            65:  out 63, r0 
            66:  out 61, r28 
            67:  pop r29 
            68:  pop r28 
            69:  ret 
            70: .Lfunc_end0: 
            71:  .size read_f32, .Lfunc_end0-read_f32 
            72:  
            73:  .section .text.read_f64,"ax",@progbits 
check:73'0                              X~~~~~~~~~~~~~~~ error: no match found
            74:  .globl read_f64 
check:73'0      ~~~~~~~~~~~~~~~~~
            75:  .p2align 1 
check:73'0      ~~~~~~~~~~~~
            76:  .type read_f64,@function 
check:73'0      ~~~~~~~~~~~~~~~~~~~~~~~~~~
            77: read_f64: 
check:73'0      ~~~~~~~~~~
            78:  push r28 
check:73'0      ~~~~~~~~~~
check:73'1       ?         possible intended match
            79:  push r29 
check:73'0      ~~~~~~~~~~
            80:  in r28, 61 
check:73'0      ~~~~~~~~~~~~
            81:  in r29, 62 
check:73'0      ~~~~~~~~~~~~
            82:  sbiw r28, 18 
check:73'0      ~~~~~~~~~~~~~~
            83:  in r0, 63 
check:73'0      ~~~~~~~~~~~
            84:  cli 
check:73'0      ~~~~~
            85:  out 62, r29 
check:73'0      ~~~~~~~~~~~~~
            86:  out 63, r0 
check:73'0      ~~~~~~~~~~~~
            87:  out 61, r28 
check:73'0      ~~~~~~~~~~~~~
            88:  movw r30, r24 
check:73'0      ~~~~~~~~~~~~~~~
            89:  std Y+8, r31 
check:73'0      ~~~~~~~~~~~~~~
            90:  std Y+7, r30 
check:73'0      ~~~~~~~~~~~~~~
            91:  ld r24, Z 
check:73'0      ~~~~~~~~~~~
            92:  ldd r25, Z+1 
check:73'0      ~~~~~~~~~~~~~~
            93:  ldd r30, Y+7 
check:73'0      ~~~~~~~~~~~~~~
            94:  ldd r31, Y+8 
check:73'0      ~~~~~~~~~~~~~~
            95:  std Y+2, r25 
check:73'0      ~~~~~~~~~~~~~~
            96:  std Y+1, r24 
check:73'0      ~~~~~~~~~~~~~~
            97:  adiw r24, 2 
check:73'0      ~~~~~~~~~~~~~
            98:  std Z+1, r25 
check:73'0      ~~~~~~~~~~~~~~
            99:  st Z, r24 
check:73'0      ~~~~~~~~~~~
           100:  ldd r30, Y+1 
check:73'0      ~~~~~~~~~~~~~~
           101:  ldd r31, Y+2 
check:73'0      ~~~~~~~~~~~~~~
           102:  ld r24, Z 
check:73'0      ~~~~~~~~~~~
           103:  ldd r25, Z+1 
check:73'0      ~~~~~~~~~~~~~~
           104:  ldd r30, Y+7 
check:73'0      ~~~~~~~~~~~~~~
           105:  ldd r31, Y+8 
check:73'0      ~~~~~~~~~~~~~~
           106:  ld r26, Z 
check:73'0      ~~~~~~~~~~~
           107:  ldd r27, Z+1 
check:73'0      ~~~~~~~~~~~~~~
           108:  ldd r30, Y+7 
check:73'0      ~~~~~~~~~~~~~~
           109:  ldd r31, Y+8 
check:73'0      ~~~~~~~~~~~~~~
           110:  std Y+4, r27 
check:73'0      ~~~~~~~~~~~~~~
           111:  std Y+3, r26 
check:73'0      ~~~~~~~~~~~~~~
           112:  adiw r26, 2 
check:73'0      ~~~~~~~~~~~~~
           113:  std Z+1, r27 
check:73'0      ~~~~~~~~~~~~~~
           114:  st Z, r26 
check:73'0      ~~~~~~~~~~~
           115:  ldd r30, Y+3 
check:73'0      ~~~~~~~~~~~~~~
           116:  ldd r31, Y+4 
check:73'0      ~~~~~~~~~~~~~~
           117:  ld r18, Z 
check:73'0      ~~~~~~~~~~~
           118:  ldd r19, Z+1 
check:73'0      ~~~~~~~~~~~~~~
           119:  ldd r30, Y+7 
check:73'0      ~~~~~~~~~~~~~~
           120:  ldd r31, Y+8 
check:73'0      ~~~~~~~~~~~~~~
           121:  ld r26, Z 
check:73'0      ~~~~~~~~~~~
           122:  ldd r27, Z+1 
check:73'0      ~~~~~~~~~~~~~~
           123:  ldd r30, Y+7 
check:73'0      ~~~~~~~~~~~~~~
           124:  ldd r31, Y+8 
check:73'0      ~~~~~~~~~~~~~~
           125:  std Y+6, r27 
check:73'0      ~~~~~~~~~~~~~~
           126:  std Y+5, r26 
check:73'0      ~~~~~~~~~~~~~~
           127:  adiw r26, 2 
check:73'0      ~~~~~~~~~~~~~
           128:  std Z+1, r27 
check:73'0      ~~~~~~~~~~~~~~
           129:  st Z, r26 
check:73'0      ~~~~~~~~~~~
           130:  ldd r30, Y+5 
check:73'0      ~~~~~~~~~~~~~~
           131:  ldd r31, Y+6 
check:73'0      ~~~~~~~~~~~~~~
           132:  ld r20, Z 
check:73'0      ~~~~~~~~~~~
           133:  ldd r21, Z+1 
check:73'0      ~~~~~~~~~~~~~~
           134:  ldd r30, Y+7 
check:73'0      ~~~~~~~~~~~~~~
           135:  ldd r31, Y+8 
check:73'0      ~~~~~~~~~~~~~~
           136:  ld r26, Z 
check:73'0      ~~~~~~~~~~~
           137:  ldd r27, Z+1 
check:73'0      ~~~~~~~~~~~~~~
           138:  ldd r30, Y+7 
check:73'0      ~~~~~~~~~~~~~~
           139:  ldd r31, Y+8 
check:73'0      ~~~~~~~~~~~~~~
           140:  std Y+10, r27 
check:73'0      ~~~~~~~~~~~~~~~
           141:  std Y+9, r26 
check:73'0      ~~~~~~~~~~~~~~
           142:  adiw r26, 2 
check:73'0      ~~~~~~~~~~~~~
           143:  std Z+1, r27 
check:73'0      ~~~~~~~~~~~~~~
           144:  st Z, r26 
check:73'0      ~~~~~~~~~~~
           145:  ldd r30, Y+9 
check:73'0      ~~~~~~~~~~~~~~
           146:  ldd r31, Y+10 
check:73'0      ~~~~~~~~~~~~~~~
           147:  ld r22, Z 
check:73'0      ~~~~~~~~~~~
           148:  ldd r23, Z+1 
check:73'0      ~~~~~~~~~~~~~~
           149:  std Y+18, r23 
check:73'0      ~~~~~~~~~~~~~~~
           150:  std Y+17, r22 
check:73'0      ~~~~~~~~~~~~~~~
           151:  std Y+16, r21 
check:73'0      ~~~~~~~~~~~~~~~
           152:  std Y+15, r20 
check:73'0      ~~~~~~~~~~~~~~~
           153:  std Y+14, r19 
check:73'0      ~~~~~~~~~~~~~~~
           154:  std Y+13, r18 
check:73'0      ~~~~~~~~~~~~~~~
           155:  std Y+12, r25 
check:73'0      ~~~~~~~~~~~~~~~
           156:  std Y+11, r24 
check:73'0      ~~~~~~~~~~~~~~~
           157:  ldd r18, Y+11 
check:73'0      ~~~~~~~~~~~~~~~
           158:  ldd r19, Y+12 
check:73'0      ~~~~~~~~~~~~~~~
           159:  ldd r20, Y+13 
check:73'0      ~~~~~~~~~~~~~~~
           160:  ldd r21, Y+14 
check:73'0      ~~~~~~~~~~~~~~~
           161:  ldd r22, Y+15 
check:73'0      ~~~~~~~~~~~~~~~
           162:  ldd r23, Y+16 
check:73'0      ~~~~~~~~~~~~~~~
           163:  ldd r24, Y+17 
check:73'0      ~~~~~~~~~~~~~~~
           164:  ldd r25, Y+18 
check:73'0      ~~~~~~~~~~~~~~~
           165:  adiw r28, 18 
check:73'0      ~~~~~~~~~~~~~~
           166:  in r0, 63 
check:73'0      ~~~~~~~~~~~
           167:  cli 
check:73'0      ~~~~~
           168:  out 62, r29 
check:73'0      ~~~~~~~~~~~~~
           169:  out 63, r0 
check:73'0      ~~~~~~~~~~~~
           170:  out 61, r28 
check:73'0      ~~~~~~~~~~~~~
           171:  pop r29 
check:73'0      ~~~~~~~~~
           172:  pop r28 
check:73'0      ~~~~~~~~~
           173:  ret 
check:73'0      ~~~~~
           174: .Lfunc_end1: 
check:73'0      ~~~~~~~~~~~~~
           175:  .size read_f64, .Lfunc_end1-read_f64 
check:73'0      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           176:  
check:73'0      ~
           177:  .section .text.read_i16,"ax",@progbits 
check:73'0      ~~~~~~~~~~~~~~~~~~~~~~~~
           178:  .globl read_i16 
           179:  .p2align 1 
           180:  .type read_i16,@function 
           181: read_i16: 
           182:  push r28 
           183:  push r29 
           184:  in r28, 61 
           185:  in r29, 62 
           186:  sbiw r28, 6 
           187:  in r0, 63 
           188:  cli 
           189:  out 62, r29 
           190:  out 63, r0 
           191:  out 61, r28 
           192:  movw r30, r24 
           193:  std Y+2, r31 
           194:  std Y+1, r30 
           195:  ld r24, Z 
next:125         !~~~~~~~~  error: match on wrong line
           196:  ldd r25, Z+1 
           197:  ldd r30, Y+1 
           198:  ldd r31, Y+2 
           199:  std Y+4, r25 
           200:  std Y+3, r24 
           201:  adiw r24, 2 
           202:  std Z+1, r25 
           203:  st Z, r24 
           204:  ldd r30, Y+3 
           205:  ldd r31, Y+4 
           206:  ld r24, Z 
           207:  ldd r25, Z+1 
           208:  std Y+6, r25 
           209:  std Y+5, r24 
           210:  ldd r24, Y+5 
           211:  ldd r25, Y+6 
           212:  adiw r28, 6 
           213:  in r0, 63 
           214:  cli 
           215:  out 62, r29 
           216:  out 63, r0 
           217:  out 61, r28 
           218:  pop r29 
           219:  pop r28 
           220:  ret 
           221: .Lfunc_end2: 
           222:  .size read_i16, .Lfunc_end2-read_i16 
           223:  
           224:  .section .text.read_i32,"ax",@progbits 
           225:  .globl read_i32 
           226:  .p2align 1 
           227:  .type read_i32,@function 
           228: read_i32: 
           229:  push r28 
           230:  push r29 
           231:  in r28, 61 
           232:  in r29, 62 
           233:  sbiw r28, 10 
           234:  in r0, 63 
           235:  cli 
           236:  out 62, r29 
           237:  out 63, r0 
           238:  out 61, r28 
           239:  movw r30, r24 
           240:  std Y+4, r31 
           241:  std Y+3, r30 
           242:  ld r24, Z 
next:143         !~~~~~~~~  error: match on wrong line
           243:  ldd r25, Z+1 
           244:  ldd r30, Y+3 
           245:  ldd r31, Y+4 
           246:  std Y+2, r25 
           247:  std Y+1, r24 
           248:  adiw r24, 2 
           249:  std Z+1, r25 
           250:  st Z, r24 
           251:  ldd r30, Y+1 
           252:  ldd r31, Y+2 
           253:  ld r24, Z 
           254:  ldd r25, Z+1 
           255:  ldd r30, Y+3 
           256:  ldd r31, Y+4 
           257:  ld r26, Z 
           258:  ldd r27, Z+1 
           259:  ldd r30, Y+3 
           260:  ldd r31, Y+4 
           261:  std Y+6, r27 
           262:  std Y+5, r26 
           263:  adiw r26, 2 
           264:  std Z+1, r27 
           265:  st Z, r26 
           266:  ldd r30, Y+5 
           267:  ldd r31, Y+6 
           268:  ld r18, Z 
           269:  ldd r19, Z+1 
           270:  std Y+10, r19 
           271:  std Y+9, r18 
           272:  std Y+8, r25 
           273:  std Y+7, r24 
           274:  ldd r22, Y+7 
           275:  ldd r23, Y+8 
           276:  ldd r24, Y+9 
           277:  ldd r25, Y+10 
           278:  adiw r28, 10 
           279:  in r0, 63 
           280:  cli 
           281:  out 62, r29 
           282:  out 63, r0 
           283:  out 61, r28 
           284:  pop r29 
           285:  pop r28 
           286:  ret 
           287: .Lfunc_end3: 
           288:  .size read_i32, .Lfunc_end3-read_i32 
           289:  
           290:  .section .text.read_i64,"ax",@progbits 
check:169'0                             X~~~~~~~~~~~~~~~ error: no match found
           291:  .globl read_i64 
check:169'0     ~~~~~~~~~~~~~~~~~
           292:  .p2align 1 
check:169'0     ~~~~~~~~~~~~
           293:  .type read_i64,@function 
check:169'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~
           294: read_i64: 
check:169'0     ~~~~~~~~~~
           295:  push r28 
check:169'0     ~~~~~~~~~~
check:169'1      ?         possible intended match
           296:  push r29 
check:169'0     ~~~~~~~~~~
           297:  in r28, 61 
check:169'0     ~~~~~~~~~~~~
           298:  in r29, 62 
check:169'0     ~~~~~~~~~~~~
           299:  sbiw r28, 18 
check:169'0     ~~~~~~~~~~~~~~
           300:  in r0, 63 
check:169'0     ~~~~~~~~~~~
           301:  cli 
check:169'0     ~~~~~
           302:  out 62, r29 
check:169'0     ~~~~~~~~~~~~~
           303:  out 63, r0 
check:169'0     ~~~~~~~~~~~~
           304:  out 61, r28 
check:169'0     ~~~~~~~~~~~~~
           305:  movw r30, r24 
check:169'0     ~~~~~~~~~~~~~~~
           306:  std Y+8, r31 
check:169'0     ~~~~~~~~~~~~~~

@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 3, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 3, 2026

💔 Test for 524fe83 failed: CI. Failed job:

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 4, 2026

PR #156043, which is a member of this rollup, was unapproved.

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants