Skip to content

Move tests array slice vec#156044

Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
danieljofficial:move-tests-array-slice-vec
May 4, 2026
Merged

Move tests array slice vec#156044
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
danieljofficial:move-tests-array-slice-vec

Conversation

@danieljofficial
Copy link
Copy Markdown
Contributor

@danieljofficial danieljofficial commented May 1, 2026

r? @Kivooeo
Hi, some tests that belong in the array-slice-vec folder

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 1, 2026
JonathanBrouwer
JonathanBrouwer approved these changes May 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@JonathanBrouwer JonathanBrouwer left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+ rollup

View changes since this review

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 3, 2026

📌 Commit f326178 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 3, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 3, 2026
@JonathanBrouwer
Rollup merge of rust-lang#156044 - danieljofficial:move-tests-array-s…
93a1109 
…lice-vec, r=JonathanBrouwer

Move tests array slice vec

r? @Kivooeo
Hi, some tests that belong in the  array-slice-vec folder
@JonathanBrouwer JonathanBrouwer mentioned this pull request May 3, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request May 3, 2026
@bors
Auto merge of #156117 - JonathanBrouwer:rollup-IcBHYEl, r=JonathanBro…
524fe83 
…uwer

Rollup of 2 pull requests

Successful merges:

 - #156043 (c-variadic: gate `va_arg` on `c_variadic_experimental_arch`)
 - #156044 (Move tests array slice vec)
jhpratt added a commit to jhpratt/rust that referenced this pull request May 3, 2026
@jhpratt
Rollup merge of rust-lang#156044 - danieljofficial:move-tests-array-s…
1405248 
…lice-vec, r=JonathanBrouwer

Move tests array slice vec

r? @Kivooeo
Hi, some tests that belong in the  array-slice-vec folder
@jhpratt jhpratt mentioned this pull request May 3, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request May 4, 2026
@bors
Auto merge of #156126 - jhpratt:rollup-9kF5MBc, r=jhpratt
61570cf 
Rollup of 2 pull requests

Successful merges:

 - #156043 (c-variadic: gate `va_arg` on `c_variadic_experimental_arch`)
 - #156044 (Move tests array slice vec)
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 4, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 4, 2026

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 14m 58s
Pushing a51f3a8 to main...

@rust-bors rust-bors Bot merged commit a51f3a8 into rust-lang:main May 4, 2026
12 checks passed
@rustbot rustbot added this to the 1.97.0 milestone May 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 045b177 (parent) -> a51f3a8 (this PR)

Test differences

Show 14 test diffs

Stage 1

  • [ui] tests/ui/array-slice-vec/slice-subslice-ref-lifetime.rs: [missing] -> pass (J1)
  • [ui] tests/ui/array-slice-vec/subslice-range-return-ref.rs: [missing] -> pass (J1)
  • [ui] tests/ui/array-slice-vec/vec-index-bounds-check-overflow.rs: [missing] -> pass (J1)
  • [ui] tests/ui/issues/issue-2470-bounds-check-overflow.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-3888-2.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-4464.rs: pass -> [missing] (J1)

Stage 2

  • [ui] tests/ui/array-slice-vec/slice-subslice-ref-lifetime.rs: [missing] -> pass (J0)
  • [ui] tests/ui/array-slice-vec/subslice-range-return-ref.rs: [missing] -> pass (J0)
  • [ui] tests/ui/array-slice-vec/vec-index-bounds-check-overflow.rs: [missing] -> pass (J0)
  • [ui] tests/ui/issues/issue-2470-bounds-check-overflow.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-3888-2.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-4464.rs: pass -> [missing] (J0)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard a51f3a89b2fffc6ce38f484d7cbf9dc25b0fe791 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. optional-x86_64-gnu-parallel-frontend: 1h 46m -> 2h 23m (+35.1%)
  2. i686-gnu-nopt-2: 1h 39m -> 2h 13m (+33.8%)
  3. x86_64-gnu-llvm-22-1: 51m 52s -> 1h 6m (+27.6%)
  4. x86_64-mingw-2: 2h 10m -> 2h 43m (+25.3%)
  5. i686-msvc-2: 2h 15m -> 1h 44m (-22.7%)
  6. dist-various-2: 43m 32s -> 34m 44s (-20.2%)
  7. dist-loongarch64-linux: 1h 48m -> 1h 28m (-18.3%)
  8. x86_64-gnu-llvm-21-2: 1h 20m -> 1h 34m (+16.7%)
  9. dist-apple-various: 1h 32m -> 1h 46m (+15.1%)
  10. dist-aarch64-linux: 1h 45m -> 1h 59m (+12.7%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Copy Markdown
Collaborator

rust-timer commented May 4, 2026

Finished benchmarking commit (a51f3a8): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.1% [0.0%, 0.1%] 5
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.2% [-0.6%, -0.0%] 4
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary 1.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.4% [0.4%, 7.4%] 6
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.7% [-2.7%, -2.7%] 1
All ❌✅ (primary) - - 0

Cycles

Results (primary -2.4%, secondary -0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.8% [0.4%, 5.4%] 8
Improvements ✅
(primary)		 -2.4% [-2.4%, -2.4%] 1
Improvements ✅
(secondary)		 -3.3% [-5.5%, -0.4%] 9
All ❌✅ (primary) -2.4% [-2.4%, -2.4%] 1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 496.439s -> 501.019s (0.92%)
Artifact size: 394.45 MiB -> 396.46 MiB (0.51%)

@rustbot rustbot added the perf-regression Performance regression. label May 4, 2026
@panstromek
Copy link
Copy Markdown
Contributor

panstromek commented May 5, 2026

perf triage:

These results are noise, this PR doesn't modify the compiler.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonathanBrouwer JonathanBrouwer JonathanBrouwer approved these changes

Assignees

@Kivooeo Kivooeo

Labels

merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

6 participants

@danieljofficial @rust-timer @panstromek @JonathanBrouwer @rustbot @Kivooeo