rustdoc-json: fix incorrect documentation for VariantKind::Struct#153573
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Mar 9, 2026
Merged
rustdoc-json: fix incorrect documentation for VariantKind::Struct#153573rust-bors[bot] merged 1 commit intorust-lang:mainfrom
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing |
Collaborator
|
rustbot has assigned @GuillaumeGomez. Use Why was this reviewer chosen?The reviewer was selected based on:
|
obi1kenobi
approved these changes
Mar 8, 2026
GuillaumeGomez
approved these changes
Mar 8, 2026
Member
|
@bors r=obi1kenobi,GuillaumeGomez rollup |
Contributor
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 9, 2026
…uwer Rollup of 6 pull requests Successful merges: - #152535 (std: use `OnceLock` for Xous environment variables) - #152646 (Update `UnsafeUnpin` impls involving extern types.) - #153559 (Inline and simplify some code for saving incremental data to disk) - #151900 (num: Separate public API from internal implementations) - #153520 (.mailmap: fix broken line with multiple emails) - #153573 (rustdoc-json: fix incorrect documentation for VariantKind::Struct) Failed merges: - #153509 (Cleanup unused diagnostic emission methods - part 2)
rust-timer
added a commit
that referenced
this pull request
Mar 9, 2026
Rollup merge of #153573 - yshui-forks:rustdoc-types-doc, r=obi1kenobi,GuillaumeGomez rustdoc-json: fix incorrect documentation for VariantKind::Struct Seems to have been copy-and-pasted from `Enum::variants`, but `VariantKind::Struct::fields` is for struct variant fields, not enum variants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems to have been copy-and-pasted from
Enum::variants, butVariantKind::Struct::fieldsis for struct variant fields, not enum variants.