num: Separate public API from internal implementations#151900
Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom Mar 9, 2026
Merged
num: Separate public API from internal implementations#151900rust-bors[bot] merged 2 commits intorust-lang:mainfrom
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
Conversation
Collaborator
This comment has been minimized.
This comment has been minimized.
e55063a to
b45018d
Compare
Collaborator
|
|
This comment has been minimized.
This comment has been minimized.
8ecf216 to
7aa5a95
Compare
This comment has been minimized.
This comment has been minimized.
Currently we have a single `core::num` module that contains both thin wrapper API and higher-complexity numeric routines. Restructure this by moving implementation details to a new `imp` module. This results in a more clean separation of what is actually user-facing compared to items that have a stability attribute because they are public for testing.
7aa5a95 to
9da93f9
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
9da93f9 to
2d1be41
Compare
This comment has been minimized.
This comment has been minimized.
2d1be41 to
f2132b0
Compare
Follow up to the previous commit refactoring `core::num` by moving the user-facing error types and trait implementations back out of `imp` and into a new module under `core::num`.
f2132b0 to
07537b4
Compare
Contributor
Author
|
Finally! @rustbot ready |
Contributor
Author
|
Think Scott has been a bit busy, so @rustbot reroll |
Member
|
@bors r+ rollup |
Contributor
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 9, 2026
…uwer Rollup of 6 pull requests Successful merges: - #152535 (std: use `OnceLock` for Xous environment variables) - #152646 (Update `UnsafeUnpin` impls involving extern types.) - #153559 (Inline and simplify some code for saving incremental data to disk) - #151900 (num: Separate public API from internal implementations) - #153520 (.mailmap: fix broken line with multiple emails) - #153573 (rustdoc-json: fix incorrect documentation for VariantKind::Struct) Failed merges: - #153509 (Cleanup unused diagnostic emission methods - part 2)
rust-timer
added a commit
that referenced
this pull request
Mar 9, 2026
Rollup merge of #151900 - tgross35:num-internal-imp, r=Mark-Simulacrum num: Separate public API from internal implementations Currently we have a single `core::num` module that contains both thin wrapper API and higher-complexity numeric routines. Restructure this by moving implementation details to a new `imp` module. This results in a more clean separation of what is actually user-facing compared to items that have a stability attribute because they are public for testing. The first commit does the actual change then the second moves a portion back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we have a single
core::nummodule that contains both thin wrapper API and higher-complexity numeric routines. Restructure this by moving implementation details to a newimpmodule.This results in a more clean separation of what is actually user-facing compared to items that have a stability attribute because they are public for testing.
The first commit does the actual change then the second moves a portion back.