Skip to content

Fix LegacyKeyValueFormat report from docker build#152305

Closed
homersimpsons wants to merge 1 commit intorust-lang:mainfrom
homersimpsons:chore/fix-LegacyKeyValueFormat
Closed

Fix LegacyKeyValueFormat report from docker build#152305
homersimpsons wants to merge 1 commit intorust-lang:mainfrom
homersimpsons:chore/fix-LegacyKeyValueFormat

Conversation

@homersimpsons
Copy link
Contributor

@homersimpsons homersimpsons commented Feb 7, 2026 •
edited
Loading

Merge split (requested in #152305 (comment)):

  1. aarch64-gnu-debug (1): Fix LegacyKeyValueFormat report from docker build: aarch64-gnu-debug #153109
  2. aarch64 (3): Fix LegacyKeyValueFormat report from docker build: host-aarch64 #153223
  3. disabled/ (11): Fix LegacyKeyValueFormat report from docker build: disabled #153224
  4. arm (7): Fix LegacyKeyValueFormat report from docker build: arm #153371
  5. x86_64-gnu (10): Fix LegacyKeyValueFormat report from docker build: x86_64-gnu #153372
  6. dist-x86_64 (6): Fix LegacyKeyValueFormat report from docker build: dist-x86_64 #153374
  7. powerpc (5): Fix LegacyKeyValueFormat report from docker build: powerpc #153373
  8. i686 (4): Fix LegacyKeyValueFormat report from docker build: i686 #153526
  9. ohos (2): Fix LegacyKeyValueFormat report from docker build: ohos #153527
  10. mips (4): Fix LegacyKeyValueFormat report from docker build: mips #153528
  11. pr-check-1, pr-check-2, tidy (3): Fix LegacyKeyValueFormat report from docker build: pr #153529
  12. dist-various-1, dist-various-2, test-various (3): Fix LegacyKeyValueFormat report from docker build: various #153531
  13. dist-android, dist-loongarch64-linux, dist-loongarch64-musl, dist-riscv64-linux, dist-s390x-linux, dist-sparcv9-solaris, x86_64-fuchsia, x86_64-rust-for-linux (8): Fix LegacyKeyValueFormat report from docker build: miscellaneous #153533

While checking job logs (https://github.com/rust-lang/rust/actions/runs/21779827147/job/62842068357#step:28:217) I noticed:

   2 warnings found (use docker --debug to expand):
   - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 24)
   - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 29)

I identified warnings with:

git ls-files --directory **/Dockerfile | sed -E -e "s/(\/Dockerfile)//" |xargs --verbose --replace={} docker build --check {}

I went with ENV ENVVAR="quoted" because it is the most working solution I found. Note that I did not touch lines that did not report a warning but that were written as ENV ENVVAR=unquoted or ENV ENVVAR=multi \\n line.

FROM alpine

ENV INLINE_UNQUOTE=this is a test
ENV INLINE_QUOTE="this is a test"
ENV MULTILINE_UNQUOTE= \
  this \
  is \
  a \
  test
ENV MULTILINE_QUOTE="\
  this \
  is \
  a \
  test"

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Feb 7, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 7, 2026

r? @marcoieni

rustbot has assigned @marcoieni.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: infra-ci
  • infra-ci expanded to Kobzol, Mark-Simulacrum, jdno, jieyouxu, marcoieni
  • Random selection from Mark-Simulacrum, jdno, jieyouxu, marcoieni

homersimpsons
homersimpsons commented Feb 7, 2026
View reviewed changes
src/ci/docker/host-aarch64/dist-aarch64-linux/Dockerfile
@@ -76,7 +76,7 @@ ENV HOSTS=aarch64-unknown-linux-gnu

ENV CPATH=/usr/include/aarch64-linux-gnu/:$CPATH
Copy link
Contributor Author

@homersimpsons homersimpsons Feb 7, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that here docker reports:

WARNING: UndefinedVar - https://docs.docker.com/go/dockerfile/rule/undefined-var/
Usage of undefined variable '$CPATH' (did you mean $PATH?)
src/ci/docker/host-aarch64/dist-aarch64-linux/Dockerfile:77
--------------------
  75 |     ENV HOSTS=aarch64-unknown-linux-gnu
  76 |
  77 | >>> ENV CPATH=/usr/include/aarch64-linux-gnu/:$CPATH
  78 |
  79 |     ENV RUST_CONFIGURE_ARGS=" \

I'm not sure if this warning should be fixed or if there is an error regarding this.

(That is the sole remaining warning after this commit)

homersimpsons
homersimpsons commented Feb 7, 2026
View reviewed changes
homersimpsons
homersimpsons commented Feb 7, 2026
View reviewed changes
@rust-log-analyzer

This comment has been minimized.

Sign in to view
homersimpsons
homersimpsons commented Feb 7, 2026
View reviewed changes
src/ci/docker/host-x86_64/x86_64-gnu-distcheck/Dockerfile
@@ -1,5 +1,5 @@
# Runs `distcheck`, which is a collection of smoke tests:
#
#
Copy link
Contributor Author

@homersimpsons homersimpsons Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My IDE probably did that, should I revert?

homersimpsons
homersimpsons commented Feb 8, 2026
View reviewed changes
@homersimpsons homersimpsons marked this pull request as draft February 8, 2026 11:38
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2026
@homersimpsons homersimpsons force-pushed the chore/fix-LegacyKeyValueFormat branch from e408c33 to 23a41c9 Compare February 8, 2026 12:54
@rust-log-analyzer

This comment has been minimized.

Sign in to view
homersimpsons
homersimpsons commented Feb 8, 2026
View reviewed changes
@homersimpsons homersimpsons force-pushed the chore/fix-LegacyKeyValueFormat branch from 23a41c9 to baef5fd Compare February 8, 2026 13:04
@homersimpsons homersimpsons marked this pull request as ready for review February 8, 2026 13:06
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 8, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@homersimpsons homersimpsons force-pushed the chore/fix-LegacyKeyValueFormat branch from baef5fd to 2ecbcb8 Compare February 8, 2026 22:26
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@homersimpsons homersimpsons force-pushed the chore/fix-LegacyKeyValueFormat branch from 2ecbcb8 to 20f7242 Compare February 8, 2026 23:35
homersimpsons
homersimpsons commented Feb 8, 2026
View reviewed changes
@homersimpsons homersimpsons force-pushed the chore/fix-LegacyKeyValueFormat branch from 20f7242 to ad71a75 Compare February 8, 2026 23:41
@rustbot

This comment was marked as outdated.

Sign in to view
@rustbot rustbot added the A-rustc-dev-guide Area: rustc-dev-guide label Feb 8, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 28, 2026
@JonathanBrouwer
Rollup merge of rust-lang#153109 - homersimpsons:chore/fix-LegacyKeyV…
5c00795 
…alueFormat-aarch64-gnu-debug, r=marcoieni

Fix LegacyKeyValueFormat report from docker build: aarch64-gnu-debug

Part of rust-lang#152305

r? @marcoieni
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 28, 2026
@JonathanBrouwer
Rollup merge of rust-lang#153109 - homersimpsons:chore/fix-LegacyKeyV…
185833e 
…alueFormat-aarch64-gnu-debug, r=marcoieni

Fix LegacyKeyValueFormat report from docker build: aarch64-gnu-debug

Part of rust-lang#152305

r? @marcoieni
rust-timer added a commit that referenced this pull request Feb 28, 2026
@rust-timer
Unrolled build for #153109
93cddab 
Rollup merge of #153109 - homersimpsons:chore/fix-LegacyKeyValueFormat-aarch64-gnu-debug, r=marcoieni

Fix LegacyKeyValueFormat report from docker build: aarch64-gnu-debug

Part of #152305

r? @marcoieni
@homersimpsons homersimpsons mentioned this pull request Feb 28, 2026
Merged
@homersimpsons
Copy link
Contributor Author

homersimpsons commented Feb 28, 2026 •
edited
Loading

I keep this merge request open for reference.

Well, while the diff can be used for reference it does not make sense to keep it open. Closing it to remove noise.

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 28, 2026
@homersimpsons homersimpsons mentioned this pull request Feb 28, 2026
Merged
github-actions bot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Mar 2, 2026
@JonathanBrouwer
Rollup merge of #153109 - homersimpsons:chore/fix-LegacyKeyValueForma…
85f699b 
…t-aarch64-gnu-debug, r=marcoieni

Fix LegacyKeyValueFormat report from docker build: aarch64-gnu-debug

Part of rust-lang/rust#152305

r? @marcoieni
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 3, 2026
@JonathanBrouwer
Rollup merge of rust-lang#153223 - homersimpsons:chore/fix-LegacyKeyV…
1ca049a 
…alueFormat-aarch64, r=marcoieni

Fix LegacyKeyValueFormat report from docker build: host-aarch64

Part of rust-lang#152305

Following rust-lang#153109

r? @marcoieni
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 3, 2026
@JonathanBrouwer
Rollup merge of rust-lang#153223 - homersimpsons:chore/fix-LegacyKeyV…
340497d 
…alueFormat-aarch64, r=marcoieni

Fix LegacyKeyValueFormat report from docker build: host-aarch64

Part of rust-lang#152305

Following rust-lang#153109

r? @marcoieni
rust-timer added a commit that referenced this pull request Mar 3, 2026
@rust-timer
Unrolled build for #153223
fd394ae 
Rollup merge of #153223 - homersimpsons:chore/fix-LegacyKeyValueFormat-aarch64, r=marcoieni

Fix LegacyKeyValueFormat report from docker build: host-aarch64

Part of #152305

Following #153109

r? @marcoieni
This was referenced Mar 3, 2026
Merged
Open
Open
Open
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 4, 2026
@matthiaskrgr
Rollup merge of rust-lang#153224 - homersimpsons:chore/fix-LegacyKeyV…
93838f1 
…alueFormat-disabled, r=marcoieni

Fix LegacyKeyValueFormat report from docker build: disabled

Part of rust-lang#152305

Following rust-lang#153109

r? @marcoieni
rust-timer added a commit that referenced this pull request Mar 4, 2026
@rust-timer
Unrolled build for #153224
ecf644d 
Rollup merge of #153224 - homersimpsons:chore/fix-LegacyKeyValueFormat-disabled, r=marcoieni

Fix LegacyKeyValueFormat report from docker build: disabled

Part of #152305

Following #153109

r? @marcoieni
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 7, 2026
@JonathanBrouwer
Rollup merge of rust-lang#153371 - homersimpsons:chore/fix-LegacyKeyV…
ec5e4aa 
…alueFormat-arm, r=marcoieni

Fix LegacyKeyValueFormat report from docker build: arm

Part of rust-lang#152305

r? @marcoieni
rust-timer added a commit that referenced this pull request Mar 7, 2026
@rust-timer
Unrolled build for #153371
d6f4507 
Rollup merge of #153371 - homersimpsons:chore/fix-LegacyKeyValueFormat-arm, r=marcoieni

Fix LegacyKeyValueFormat report from docker build: arm

Part of #152305

r? @marcoieni
This was referenced Mar 7, 2026
Open
Merged
Open
Open
Open
Open
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 9, 2026
@JonathanBrouwer
Rollup merge of rust-lang#153527 - homersimpsons:chore/fix-LegacyKeyV…
4ff5147 
…alueFormat-ohos, r=marcoieni

Fix LegacyKeyValueFormat report from docker build: ohos

Part of rust-lang#152305

r? @marcoieni
rust-timer added a commit that referenced this pull request Mar 9, 2026
@rust-timer
Unrolled build for #153527
169c7d0 
Rollup merge of #153527 - homersimpsons:chore/fix-LegacyKeyValueFormat-ohos, r=marcoieni

Fix LegacyKeyValueFormat report from docker build: ohos

Part of #152305

r? @marcoieni
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 10, 2026
@JonathanBrouwer
Rollup merge of rust-lang#153533 - homersimpsons:chore/fix-LegacyKeyV…
db1702f 
…alueFormat-miscellaneous, r=marcoieni

Fix LegacyKeyValueFormat report from docker build: miscellaneous

Part of rust-lang#152305

Those are the remaining Dockerfile to fix once the other merge requests are merged. Note that this merge request can still be merged before the others.

r? @marcoieni
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 10, 2026
@JonathanBrouwer
Rollup merge of rust-lang#153533 - homersimpsons:chore/fix-LegacyKeyV…
9b706a7 
…alueFormat-miscellaneous, r=marcoieni

Fix LegacyKeyValueFormat report from docker build: miscellaneous

Part of rust-lang#152305

Those are the remaining Dockerfile to fix once the other merge requests are merged. Note that this merge request can still be merged before the others.

r? @marcoieni
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@marcoieni marcoieni

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@homersimpsons @rustbot @rust-log-analyzer @marcoieni @reddevilmidzy