Fix LegacyKeyValueFormat report from docker build: pr#153529
Open
homersimpsons wants to merge 1 commit intorust-lang:mainfrom
Open
Fix LegacyKeyValueFormat report from docker build: pr#153529homersimpsons wants to merge 1 commit intorust-lang:mainfrom
homersimpsons wants to merge 1 commit intorust-lang:mainfrom
Conversation
homersimpsons
commented
Mar 7, 2026
Comment on lines
+42
to
45
| ENV SCRIPT=" \ | ||
| # Check some tools that aren't included in `x check` by default, to | ||
| # ensure that maintainers can still do check builds locally. | ||
| python3 ../x.py check \ |
Contributor
Author
There was a problem hiding this comment.
@marcoieni How would you like to handle this? (1 or 4 or other solution?)
Original outputs:
ENV SCRIPT_SOURCE \
# Check some tools that aren't included in `x check` by default, to
# ensure that maintainers can still do check builds locally.
python3 ../x.py checkSCRIPT_SOURCE=python3 ../x.py check- This outputs spaces:
ENV SCRIPT=" \
# Check some tools that aren't included in `x check` by default, to
# ensure that maintainers can still do check builds locally.
python3 ../x.py check"SCRIPT_TARGET= python3 ../x.py check- This does not compile:
ENV SCRIPT_TARGET="#Check some tools that aren't included in `x check` by default, to
# ensure that maintainers can still do check builds locally.
python3 ../x.py check"Dockerfile:9
--------------------
7 | ENV SCRIPT_TARGET="#Check some tools that aren't included in `x check` by default, to
8 | # ensure that maintainers can still do check builds locally.
9 | >>> python3 ../x.py check"
10 |
11 | CMD ["printenv"]
--------------------
ERROR: failed to build: failed to solve: dockerfile parse error on line 9: unknown instruction: python3- This does not work as it compiles with the comment inline:
ENV SCRIPT_TARGET="#Check some tools that aren't included in `x check` by default, to \
# ensure that maintainers can still do check builds locally.
python3 ../x.py check"SCRIPT_TARGET=#Check some tools that aren't included in `x check` by default, to python3 ../x.py check- This works, moving the comment:
# Check some tools that aren't included in `x check` by default, to
# ensure that maintainers can still do check builds locally.
ENV SCRIPT_TARGET="python3 ../x.py check"SCRIPT_TARGET=python3 ../x.py check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #152305
r? @marcoieni