make attrs actually use Target::GenericParam
#150829
Merged
+47
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing |
Contributor
|
@bors r+ rollup |
Contributor
rust-bors bot
added a commit
that referenced
this pull request
Jan 9, 2026
Rollup of 11 pull requests Successful merges: - #150272 (docs(core): update `find()` and `rfind()` examples) - #150385 (fix `Expr::can_have_side_effects` for `[x; N]` style array literal and binary expressions) - #150561 (Finish transition from `semitransparent` to `semiopaque` for `rustc_macro_transparency`) - #150574 (Clarify `MoveData::init_loc_map`.) - #150762 (Use functions more in rustdoc GUI tests) - #150808 (rename the `derive_{eq, clone_copy}` features to `*_internals`) - #150816 (Fix trait method anchor disappearing before user can click on it) - #150821 (tests/ui/borrowck/issue-92157.rs: Remove (bug not fixed)) - #150829 (make attrs actually use `Target::GenericParam`) - #150834 (Add tracking issue for `feature(multiple_supertrait_upcastable)`) - #150864 (The aarch64-unknown-none target requires NEON, so the docs were wrong.) r? @ghost
rust-timer
added a commit
that referenced
this pull request
Jan 9, 2026
Rollup merge of #150829 - fix_generic_param_target, r=JonathanBrouwer make attrs actually use `Target::GenericParam` currently attributes lower `GenericParam` -> `Target::Param` this PR fixes this, so that `GenericParam` is lowered to `Target::GenericParam` r? @JonathanBrouwer
github-actions bot
pushed a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Jan 12, 2026
Rollup of 11 pull requests Successful merges: - rust-lang/rust#150272 (docs(core): update `find()` and `rfind()` examples) - rust-lang/rust#150385 (fix `Expr::can_have_side_effects` for `[x; N]` style array literal and binary expressions) - rust-lang/rust#150561 (Finish transition from `semitransparent` to `semiopaque` for `rustc_macro_transparency`) - rust-lang/rust#150574 (Clarify `MoveData::init_loc_map`.) - rust-lang/rust#150762 (Use functions more in rustdoc GUI tests) - rust-lang/rust#150808 (rename the `derive_{eq, clone_copy}` features to `*_internals`) - rust-lang/rust#150816 (Fix trait method anchor disappearing before user can click on it) - rust-lang/rust#150821 (tests/ui/borrowck/issue-92157.rs: Remove (bug not fixed)) - rust-lang/rust#150829 (make attrs actually use `Target::GenericParam`) - rust-lang/rust#150834 (Add tracking issue for `feature(multiple_supertrait_upcastable)`) - rust-lang/rust#150864 (The aarch64-unknown-none target requires NEON, so the docs were wrong.) r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently attributes lower
GenericParam->Target::Paramthis PR fixes this, so thatGenericParamis lowered toTarget::GenericParamr? @JonathanBrouwer