Skip to content

Conversation

@Enselic
Copy link
Member

@Enselic Enselic commented Jan 8, 2026

The bug the test tests for is masked by the wrong #[lang = "start"] signature. If the signature is corrected, the test builds. But that is not because the bug is fixed, but because the test has been changed too much from the original reproducer. The original reproducer still ICE:s. See #92157 (comment).

But that's fine since in the latest compiler says:

note: using internal features is not supported and expected to cause internal compiler errors when used incorrectly

So let's remove the test and close the issue as "won't fix". See #92157 (comment).

r? @JohnTitor since you added the test in #106878

@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 8, 2026
@jackh726
Copy link
Member

jackh726 commented Jan 8, 2026

@bors r+ rollup

And please close the linked issue

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 8, 2026

📌 Commit 6ed9530 has been approved by jackh726

It is now in the queue for this repository.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 9, 2026
tests/ui/borrowck/issue-92157.rs: Remove (bug not fixed)

The bug the test tests for is masked by the wrong `#[lang = "start"]` signature. If the signature is corrected, the test builds. But that is not because the bug is fixed, but because the test has been changed too much from the original reproducer. The original reproducer still ICE:s. See rust-lang#92157 (comment).

But that's fine since in the latest compiler says:

> note: using internal features is not supported and expected to cause internal compiler errors when used incorrectly

So let's remove the test and close the issue as "won't fix". See rust-lang#92157 (comment).

r? @JohnTitor since you added the test in rust-lang#106878
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 9, 2026
tests/ui/borrowck/issue-92157.rs: Remove (bug not fixed)

The bug the test tests for is masked by the wrong `#[lang = "start"]` signature. If the signature is corrected, the test builds. But that is not because the bug is fixed, but because the test has been changed too much from the original reproducer. The original reproducer still ICE:s. See rust-lang#92157 (comment).

But that's fine since in the latest compiler says:

> note: using internal features is not supported and expected to cause internal compiler errors when used incorrectly

So let's remove the test and close the issue as "won't fix". See rust-lang#92157 (comment).

r? @JohnTitor since you added the test in rust-lang#106878
rust-bors bot added a commit that referenced this pull request Jan 9, 2026
Rollup of 11 pull requests

Successful merges:

 - #150272 (docs(core): update `find()` and `rfind()` examples)
 - #150385 (fix `Expr::can_have_side_effects` for `[x; N]` style array literal and binary expressions)
 - #150561 (Finish transition from `semitransparent` to `semiopaque` for `rustc_macro_transparency`)
 - #150574 (Clarify `MoveData::init_loc_map`.)
 - #150762 (Use functions more in rustdoc GUI tests)
 - #150808 (rename the `derive_{eq, clone_copy}` features to `*_internals`)
 - #150816 (Fix trait method anchor disappearing before user can click on it)
 - #150821 (tests/ui/borrowck/issue-92157.rs: Remove (bug not fixed))
 - #150829 (make attrs actually use `Target::GenericParam`)
 - #150834 (Add tracking issue for `feature(multiple_supertrait_upcastable)`)
 - #150864 (The aarch64-unknown-none target requires NEON, so the docs were wrong.)

r? @ghost
@rust-bors rust-bors bot merged commit 19769da into rust-lang:main Jan 9, 2026
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 9, 2026
rust-timer added a commit that referenced this pull request Jan 9, 2026
Rollup merge of #150821 - remove-test, r=jackh726

tests/ui/borrowck/issue-92157.rs: Remove (bug not fixed)

The bug the test tests for is masked by the wrong `#[lang = "start"]` signature. If the signature is corrected, the test builds. But that is not because the bug is fixed, but because the test has been changed too much from the original reproducer. The original reproducer still ICE:s. See #92157 (comment).

But that's fine since in the latest compiler says:

> note: using internal features is not supported and expected to cause internal compiler errors when used incorrectly

So let's remove the test and close the issue as "won't fix". See #92157 (comment).

r? @JohnTitor since you added the test in #106878
github-actions bot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Jan 12, 2026
Rollup of 11 pull requests

Successful merges:

 - rust-lang/rust#150272 (docs(core): update `find()` and `rfind()` examples)
 - rust-lang/rust#150385 (fix `Expr::can_have_side_effects` for `[x; N]` style array literal and binary expressions)
 - rust-lang/rust#150561 (Finish transition from `semitransparent` to `semiopaque` for `rustc_macro_transparency`)
 - rust-lang/rust#150574 (Clarify `MoveData::init_loc_map`.)
 - rust-lang/rust#150762 (Use functions more in rustdoc GUI tests)
 - rust-lang/rust#150808 (rename the `derive_{eq, clone_copy}` features to `*_internals`)
 - rust-lang/rust#150816 (Fix trait method anchor disappearing before user can click on it)
 - rust-lang/rust#150821 (tests/ui/borrowck/issue-92157.rs: Remove (bug not fixed))
 - rust-lang/rust#150829 (make attrs actually use `Target::GenericParam`)
 - rust-lang/rust#150834 (Add tracking issue for `feature(multiple_supertrait_upcastable)`)
 - rust-lang/rust#150864 (The aarch64-unknown-none target requires NEON, so the docs were wrong.)

r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tidy Area: The tidy tool S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants