Skip to content

rustdoc: fix incorrect type filter name in help popup #150360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Dec 25, 2025
Merged

rustdoc: fix incorrect type filter name in help popup #150360

bors merged 1 commit into from
Dec 25, 2025
+1 −1

Conversation

@heathdutton
Copy link
Contributor

@heathdutton heathdutton commented Dec 25, 2025 •
edited by rustbot
Loading

Fixes #150349

The help popup states that const: is an accepted search filter, but the actual filter name is constant:. This updates the help text to match the implementation.

@rustbot
Copy link
Collaborator

rustbot commented Dec 25, 2025

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @lolbinarycat

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Dec 25, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 25, 2025

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Dec 25, 2025

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 25, 2025

📌 Commit 83749a4 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 25, 2025
@JonathanBrouwer JonathanBrouwer mentioned this pull request Dec 25, 2025
Merged
bors added a commit that referenced this pull request Dec 25, 2025
@bors
Auto merge of #150376 - JonathanBrouwer:rollup-6umj8ur, r=JonathanBro…
1bf12c3 
…uwer

Rollup of 3 pull requests

Successful merges:

 - #150360 (rustdoc: fix incorrect type filter name in help popup)
 - #150366 (Fix typos and grammar errors in README files)
 - #150371 (several `proc_macro` cleanups)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit dea3c15 into rust-lang:main Dec 25, 2025
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 25, 2025
rust-timer added a commit that referenced this pull request Dec 25, 2025
@rust-timer
Unrolled build for #150360
86388ca 
Rollup merge of #150360 - heathdutton:fix-rustdoc-const-type-filter-150349, r=GuillaumeGomez

rustdoc: fix incorrect type filter name in help popup

Fixes #150349

The help popup states that `const:` is an accepted search filter, but the actual filter name is `constant:`. This updates the help text to match the implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

Rustdoc frontend: const: type filter does not work

4 participants

@heathdutton @rustbot @GuillaumeGomez @bors