Skip to content

Rollup of 3 pull requests #150376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 6 commits into from
Dec 25, 2025
Merged

Rollup of 3 pull requests #150376

bors merged 6 commits into from
Dec 25, 2025

Conversation

@JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Dec 25, 2025 •
edited by rustbot
Loading

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

cyrgani and others added 6 commits December 23, 2025 09:56
@cyrgani
several proc_macro cleanups
01c23c6
@heathdutton
rustdoc: fix incorrect type filter name in help popup
83749a4
@maradini77
fix: typos and grammar errors in README files
fc6df9c 
- fix `FIMXE`/`FXIME` typos → `FIXME`
- fix grammar: `these terminology are` → `this terminology is`
- fix apostrophe: `it's data` → `its data`
- remove duplicate word: `less less` → `less`
@JonathanBrouwer
Rollup merge of rust-lang#150360 - heathdutton:fix-rustdoc-const-type…
dea3c15 
…-filter-150349, r=GuillaumeGomez

rustdoc: fix incorrect type filter name in help popup

Fixes rust-lang#150349

The help popup states that `const:` is an accepted search filter, but the actual filter name is `constant:`. This updates the help text to match the implementation.
@JonathanBrouwer
Rollup merge of rust-lang#150366 - maradini77:main, r=clubby789,Kivooeo
6aff90c 
Fix typos and grammar errors in README files

- Fix `FIMXE`/`FXIME` typos → `FIXME`
- Fix grammar: "these terminology are" → "this terminology is"
- Fix apostrophe: "it's data" → "its data"
- Remove duplicate word: "less less" → "less"
@JonathanBrouwer
Rollup merge of rust-lang#150371 - cyrgani:pm-cleanups-again, r=petro…
d80a406 
…chenkov

several `proc_macro` cleanups

Fixes typos and applies the suggestions from a few clippy lints that made sense here.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. rollup A PR which is a rollup labels Dec 25, 2025
@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Dec 25, 2025

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Dec 25, 2025

📌 Commit d80a406 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 25, 2025
@bors
Copy link
Collaborator

bors commented Dec 25, 2025

⌛ Testing commit d80a406 with merge 1bf12c3...

@bors bors mentioned this pull request Dec 25, 2025
Merged
@bors
Copy link
Collaborator

bors commented Dec 25, 2025

☀️ Test successful - checks-actions
Approved by: JonathanBrouwer
Pushing 1bf12c3 to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 25, 2025
@bors bors merged commit 1bf12c3 into rust-lang:main Dec 25, 2025
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 25, 2025
@rust-timer
Copy link
Collaborator

rust-timer commented Dec 25, 2025

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#150360 rustdoc: fix incorrect type filter name in help popup 86388cacd8a00ee43253a8b99bc01fcbe23e1a6a (link)
#150366 Fix typos and grammar errors in README files 78cdefde344e2e450583c6dd7e7bb3ac1db3fd8f (link)
#150371 several proc_macro cleanups 8256f440ddd1661bcbfaae2fae225bc33845ea5f (link)

previous master: a47e39ea20

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Contributor

github-actions bot commented Dec 25, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing a47e39e (parent) -> 1bf12c3 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 1bf12c32a08384862297674921d1137ad94892dc --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 9624.4s -> 10960.4s (+13.9%)
  2. pr-check-1: 1891.8s -> 1647.0s (-12.9%)
  3. aarch64-gnu-llvm-20-2: 3391.5s -> 2958.8s (-12.8%)
  4. dist-apple-various: 4048.2s -> 3548.6s (-12.3%)
  5. x86_64-gnu-miri: 4919.0s -> 4362.1s (-11.3%)
  6. i686-gnu-1: 8039.6s -> 7171.1s (-10.8%)
  7. pr-check-2: 2560.6s -> 2309.6s (-9.8%)
  8. dist-loongarch64-musl: 5742.5s -> 5197.1s (-9.5%)
  9. i686-gnu-2: 5929.6s -> 5374.0s (-9.4%)
  10. x86_64-rust-for-linux: 3135.4s -> 2843.9s (-9.3%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

rust-timer commented Dec 25, 2025

Finished benchmarking commit (1bf12c3): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.1%, secondary -0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 2.1% [2.1%, 2.1%] 1
Regressions ❌
(secondary)		 3.2% [3.2%, 3.2%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.3% [-4.3%, -4.3%] 1
All ❌✅ (primary) 2.1% [2.1%, 2.1%] 1

Cycles

Results (primary -2.7%, secondary -1.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.4% [3.4%, 3.5%] 2
Improvements ✅
(primary)		 -2.7% [-2.7%, -2.7%] 1
Improvements ✅
(secondary)		 -4.4% [-5.3%, -3.9%] 3
All ❌✅ (primary) -2.7% [-2.7%, -2.7%] 1

Binary size

Results (primary 0.1%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 0.1% [0.1%, 0.1%] 9
Regressions ❌
(secondary)		 0.1% [0.1%, 0.1%] 11
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.1% [0.1%, 0.1%] 9

Bootstrap: 482.784s -> 482.343s (-0.09%)
Artifact size: 392.42 MiB -> 392.46 MiB (0.01%)

@bors bors mentioned this pull request Dec 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

7 participants

@JonathanBrouwer @bors @rust-timer @rustbot @cyrgani @heathdutton @maradini77