refactor: remove Ord bound from BinaryHeap::new etc #149408

aatifsyed · 2025-11-28T00:59:47Z

This adds consistency with e.g BTreeMap::new, and makes it easier to e.g #[derive(Default)]¹

https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=f848e472a176fae155f17455bdfe0aee ↩

rustbot · 2025-11-28T00:59:52Z

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

tgross35 · 2025-11-29T19:13:13Z

This seems fine to me but will need libs-api FCP.

aatifsyed · 2025-11-30T01:39:39Z

Thanks! Is that this? https://rustc-dev-guide.rust-lang.org/stability.html#stabilizing-a-library-feature

What actions can I take to progress this :)

Sorry I've not made changes to std before!

tgross35 · 2025-11-30T04:34:47Z

No action needed on your end :) the label I added means it will get discussed at this week’s meeting.

Amanieu · 2025-12-02T16:58:58Z

@rfcbot merge libs-api

rust-rfcbot · 2025-12-02T16:58:59Z

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

tgross35

LGTM after FCP completes.

@BurntSushi @joshtriplett @the8472 this just needs another checkbox.

View changes since this review

rust-rfcbot · 2026-01-03T13:11:20Z

🔔 This is now entering its final comment period, as per the review above. 🔔

rust-rfcbot · 2026-01-13T13:11:44Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

dtolnay

Thanks!

dtolnay · 2026-01-13T15:08:29Z

@bors r=tgross35,dtolnay

rust-bors · 2026-01-13T15:08:31Z

📋 This PR cannot be approved because it currently has the following label: S-waiting-on-fcp.

dtolnay · 2026-01-13T15:09:38Z

@bors r=tgross35,dtolnay

rust-bors · 2026-01-13T15:09:42Z

📌 Commit fcf2426 has been approved by tgross35,dtolnay

It is now in the queue for this repository.

…ross35,dtolnay refactor: remove Ord bound from BinaryHeap::new etc This adds consistency with e.g `BTreeMap::new`, and makes it easier to e.g `#[derive(Default)]`[^1] [^1]: https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=f848e472a176fae155f17455bdfe0aee

@ghost

…uwer Rollup of 12 pull requests Successful merges: - #149408 (refactor: remove Ord bound from BinaryHeap::new etc) - #150406 (Change some `matches!(.., .. if ..)` with let-chains) - #150723 (std: move `errno` and related functions into `sys::io`) - #150877 (resolve: Refactor away the side table `decl_parent_modules`) - #150902 (Update to_uppercase docs to avoid ß->SS example) - #150962 (Remove `FeedConstTy` and provide ty when lowering const arg) - #151034 (std: Change UEFI env vars to volatile storage) - #151036 (Better handle when trying to iterate on a `Range` of a type that isn't `Step`) - #151067 (Avoid should-fail in two ui tests and a codegen-llvm test) - #151072 (also handle ENOTTY ioctl errors when checking pidfd -> pid support) - #151077 (Recognize potential `impl<const N: usize>` to `impl<N>` mistake) - #151096 (Remove `Deref`/`DerefMut` impl for `Providers`.) Failed merges: - #150939 (resolve: Relax some asserts in glob overwriting and add tests) r? @ghost

@ghost

…uwer Rollup of 11 pull requests Successful merges: - #149408 (refactor: remove Ord bound from BinaryHeap::new etc) - #150406 (Change some `matches!(.., .. if ..)` with let-chains) - #150723 (std: move `errno` and related functions into `sys::io`) - #150877 (resolve: Refactor away the side table `decl_parent_modules`) - #150902 (Update to_uppercase docs to avoid ß->SS example) - #151034 (std: Change UEFI env vars to volatile storage) - #151036 (Better handle when trying to iterate on a `Range` of a type that isn't `Step`) - #151067 (Avoid should-fail in two ui tests and a codegen-llvm test) - #151072 (also handle ENOTTY ioctl errors when checking pidfd -> pid support) - #151077 (Recognize potential `impl<const N: usize>` to `impl<N>` mistake) - #151096 (Remove `Deref`/`DerefMut` impl for `Providers`.) Failed merges: - #150939 (resolve: Relax some asserts in glob overwriting and add tests) r? @ghost

Rollup merge of #149408 - aatifsyed/binary-heap-no-ord, r=tgross35,dtolnay refactor: remove Ord bound from BinaryHeap::new etc This adds consistency with e.g `BTreeMap::new`, and makes it easier to e.g `#[derive(Default)]`[^1] [^1]: https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=f848e472a176fae155f17455bdfe0aee

@ghost

…uwer Rollup of 11 pull requests Successful merges: - rust-lang/rust#149408 (refactor: remove Ord bound from BinaryHeap::new etc) - rust-lang/rust#150406 (Change some `matches!(.., .. if ..)` with let-chains) - rust-lang/rust#150723 (std: move `errno` and related functions into `sys::io`) - rust-lang/rust#150877 (resolve: Refactor away the side table `decl_parent_modules`) - rust-lang/rust#150902 (Update to_uppercase docs to avoid ß->SS example) - rust-lang/rust#151034 (std: Change UEFI env vars to volatile storage) - rust-lang/rust#151036 (Better handle when trying to iterate on a `Range` of a type that isn't `Step`) - rust-lang/rust#151067 (Avoid should-fail in two ui tests and a codegen-llvm test) - rust-lang/rust#151072 (also handle ENOTTY ioctl errors when checking pidfd -> pid support) - rust-lang/rust#151077 (Recognize potential `impl<const N: usize>` to `impl<N>` mistake) - rust-lang/rust#151096 (Remove `Deref`/`DerefMut` impl for `Providers`.) Failed merges: - rust-lang/rust#150939 (resolve: Relax some asserts in glob overwriting and add tests) r? @ghost

refactor: remove Ord bound from BinaryHeap::new etc

845da88

rustbot assigned tgross35 Nov 28, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 28, 2025

This comment has been minimized.

Sign in to view

fix: BinaryHeap<T: Ord>::peek_mut

fcf2426

hkBst approved these changes Nov 28, 2025

View reviewed changes

tgross35 added needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. I-libs-api-nominated Nominated for discussion during a libs-api team meeting. labels Nov 29, 2025

Amanieu added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 2, 2025

This comment was marked as outdated.

Sign in to view

Amanieu removed the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Dec 2, 2025

This comment was marked as outdated.

Sign in to view

rust-rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Dec 2, 2025

tgross35 approved these changes Jan 3, 2026

View reviewed changes

tgross35 added S-waiting-on-t-libs-api Status: Awaiting decision from T-libs-api and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2026

rust-rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Jan 3, 2026

Amanieu added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed S-waiting-on-t-libs-api Status: Awaiting decision from T-libs-api labels Jan 6, 2026

rustbot mentioned this pull request Jan 13, 2026

Tracking issue for release notes of #149408: refactor: remove Ord bound from BinaryHeap::new etc #151058

Open

dtolnay approved these changes Jan 13, 2026

View reviewed changes

dtolnay added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. labels Jan 13, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 13, 2026

dtolnay assigned dtolnay and unassigned tgross35 Jan 13, 2026

JonathanBrouwer mentioned this pull request Jan 14, 2026

Rollup of 12 pull requests #151104

Closed

JonathanBrouwer mentioned this pull request Jan 14, 2026

Rollup of 11 pull requests #151107

Merged

rust-bors bot merged commit 9142952 into rust-lang:main Jan 14, 2026
11 checks passed

rustbot added this to the 1.94.0 milestone Jan 14, 2026

Uh oh!

refactor: remove Ord bound from BinaryHeap::new etc #149408

refactor: remove Ord bound from BinaryHeap::new etc #149408

Conversation

aatifsyed commented Nov 28, 2025

Footnotes

Uh oh!

rustbot commented Nov 28, 2025

Uh oh!

This comment has been minimized.

tgross35 commented Nov 29, 2025

Uh oh!

aatifsyed commented Nov 30, 2025

Uh oh!

tgross35 commented Nov 30, 2025

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

Amanieu commented Dec 2, 2025

Uh oh!

rust-rfcbot commented Dec 2, 2025 • edited by BurntSushi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tgross35 left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-rfcbot commented Jan 3, 2026

Uh oh!

rust-rfcbot commented Jan 13, 2026

Uh oh!

dtolnay left a comment

Choose a reason for hiding this comment

Uh oh!

dtolnay commented Jan 13, 2026

Uh oh!

rust-bors bot commented Jan 13, 2026

Uh oh!

dtolnay commented Jan 13, 2026

Uh oh!

rust-bors bot commented Jan 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

rust-rfcbot commented Dec 2, 2025 •

edited by BurntSushi

Loading

tgross35 left a comment •

edited by rustbot

Loading