-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
Rollup of 11 pull requests #151107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 11 pull requests #151107
Conversation
The UEFI variables set by the env vars should be volatile, otherwise they will persist after reboot and use up scarce non-volatile storage.
should-fail is only meant for testing the compiletest framework itself. It checks that the test runner itself panicked.
Instead keep parent modules in `DeclData` itself
Otherwise the std testsuite fails on older kernels.
When encountering code like `impl<N> Bar<N> for [u8; N]`, suggest `impl<const N: Type> Bar<N> for [u8; N]` as a possibility.
```
error[E0423]: expected value, found type parameter `T`
--> $DIR/issue-69654.rs:5:25
|
LL | impl<T> Bar<T> for [u8; T] {}
| - ^ not a value
| |
| found this type parameter
|
help: you might have meant to write a const parameter here
|
LL | impl<const T: /* Type */> Bar<T> for [u8; T] {}
| +++++ ++++++++++++
```
It's described as a "backwards compatibility hack to keep the diff small". Removing it requires only a modest amount of churn, and the resulting code is clearer without the invisible derefs.
…ross35,dtolnay refactor: remove Ord bound from BinaryHeap::new etc This adds consistency with e.g `BTreeMap::new`, and makes it easier to e.g `#[derive(Default)]`[^1] [^1]: https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=f848e472a176fae155f17455bdfe0aee
…bk,BoxyUwU,fmease Change some `matches!(.., .. if ..)` with let-chains Follow up to rust-lang#149933.
std: move `errno` and related functions into `sys::io` Part of rust-lang#117276. Currently, `errno` and related functions like `decode_error_kind` are split across `sys::pal` and `sys::pal::os`. This PR moves all of them into a new module inside `sys::io`.
resolve: Refactor away the side table `decl_parent_modules` Instead keep parent modules in `DeclData` itself. Follow up to rust-lang#150445. r? @nnethercote
…ieb,workingjubilee Update to_uppercase docs to avoid ß->SS example Fixes rust-lang#150888 Updates the `to_uppercase` documentation examples to avoid relying on the ß → "SS" mapping and instead uses a stable multi-character case-mapping example ('ffi' → "FFI"). Note: the example uses U+FB03 (LATIN SMALL LIGATURE FFI), not the ASCII string "ffi".
std: Change UEFI env vars to volatile storage The UEFI variables set by the env vars should be volatile, otherwise they will persist after reboot and use up scarce non-volatile storage. CC @Ayush1325
Better handle when trying to iterate on a `Range` of a type that isn't `Step` Mention when a trait bound corresponds to an unstable trait. Mention `Range` when `Step` bound is unment, and explain that only some std types impl `Iterator` for `Range`. CC rust-lang#151026
Avoid should-fail in two ui tests and a codegen-llvm test `should-fail` is only meant for testing the compiletest framework itself. It checks that the test runner itself panicked. With this there are still a bunch of rustdoc-html tests that use it due to this test suite not supporting anything like `//@ doc-fail`.
|
@bors r+ rollup=never p=5 |
This comment has been minimized.
This comment has been minimized.
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 2fd6efc (parent) -> 8c52f73 (this PR) Test differencesShow 246 test diffs246 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 8c52f735abd1af9a73941b78fe7ed2ab08b9c0dd --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
📌 Perf builds for each rolled up PR:
previous master: 2fd6efc327 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (8c52f73): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary -2.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 3.0%, secondary 5.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.0%, secondary -0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 474.74s -> 472.286s (-0.52%) |
Successful merges:
matches!(.., .. if ..)with let-chains #150406 (Change somematches!(.., .. if ..)with let-chains)errnoand related functions intosys::io#150723 (std: moveerrnoand related functions intosys::io)decl_parent_modules#150877 (resolve: Refactor away the side tabledecl_parent_modules)Rangeof a type that isn'tStep#151036 (Better handle when trying to iterate on aRangeof a type that isn'tStep)impl<const N: usize>toimpl<N>mistake #151077 (Recognize potentialimpl<const N: usize>toimpl<N>mistake)Deref/DerefMutimpl forProviders. #151096 (RemoveDeref/DerefMutimpl forProviders.)Failed merges:
r? @ghost
Create a similar rollup