Add test for href of reexported enum variant#149026
Merged
bors merged 2 commits intorust-lang:mainfrom Nov 18, 2025
Merged
Conversation
Member
|
@rust-timer queue (Just testing perfbot). |
Contributor
|
The filename and comment for the new file seem quite broad, but as far as I know enum variants are the only associated items that can be reexported, so maybe that should be changed to reflect the narrowness of the test? @rustbot author |
8f6c986 to
2afc11c
Compare
Member
Author
Agreed. When I originally made the file, I thought we could reexport @rustbot ready |
Contributor
|
That's funny, I also rediscovered you can't reexport associated items in the process of reviewing this PR. I think the current file comment is ok, but could be better, maybe something like "tests that reexported enum variants correctly link to the original variant" or something. you can r=me with or without the new comment once CI is green. |
2afc11c to
db72a2d
Compare
This comment has been minimized.
This comment has been minimized.
db72a2d to
8642d82
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
Author
|
@bors r=lolbinarycat rollup |
Collaborator
bors
added a commit
that referenced
this pull request
Nov 18, 2025
Rollup of 4 pull requests Successful merges: - #148970 (std: sys: fs: uefi: Implement stat) - #149020 (flush_delayed: add note about stashed diagnostics) - #149026 (Add test for href of reexported enum variant) - #149049 (compiletest: Use JSON "binary-format" to decide `//@ only-elf` and `//@ ignore-elf`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Nov 18, 2025
Rollup merge of #149026 - GuillaumeGomez:test-for-reexported-variant, r=lolbinarycat Add test for href of reexported enum variant Working on #148648 and realized that we actually didn't test for enum variants reexports, so here we are. I also think I'll do #148648 at the same time as #148547. r? `@lolbinarycat`
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Nov 30, 2025
…llaumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#148970 (std: sys: fs: uefi: Implement stat) - rust-lang#149020 (flush_delayed: add note about stashed diagnostics) - rust-lang#149026 (Add test for href of reexported enum variant) - rust-lang#149049 (compiletest: Use JSON "binary-format" to decide `//@ only-elf` and `//@ ignore-elf`) r? `@ghost` `@rustbot` modify labels: rollup
makai410
pushed a commit
to makai410/rustc_public
that referenced
this pull request
Dec 10, 2025
Rollup of 4 pull requests Successful merges: - rust-lang/rust#148970 (std: sys: fs: uefi: Implement stat) - rust-lang/rust#149020 (flush_delayed: add note about stashed diagnostics) - rust-lang/rust#149026 (Add test for href of reexported enum variant) - rust-lang/rust#149049 (compiletest: Use JSON "binary-format" to decide `//@ only-elf` and `//@ ignore-elf`) r? `@ghost` `@rustbot` modify labels: rollup
makai410
pushed a commit
to makai410/rust
that referenced
this pull request
Dec 10, 2025
…llaumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#148970 (std: sys: fs: uefi: Implement stat) - rust-lang#149020 (flush_delayed: add note about stashed diagnostics) - rust-lang#149026 (Add test for href of reexported enum variant) - rust-lang#149049 (compiletest: Use JSON "binary-format" to decide `//@ only-elf` and `//@ ignore-elf`) r? `@ghost` `@rustbot` modify labels: rollup
Kobzol
pushed a commit
to Kobzol/rustc_codegen_cranelift
that referenced
this pull request
Dec 29, 2025
Rollup of 4 pull requests Successful merges: - rust-lang/rust#148970 (std: sys: fs: uefi: Implement stat) - rust-lang/rust#149020 (flush_delayed: add note about stashed diagnostics) - rust-lang/rust#149026 (Add test for href of reexported enum variant) - rust-lang/rust#149049 (compiletest: Use JSON "binary-format" to decide `//@ only-elf` and `//@ ignore-elf`) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on #148648 and realized that we actually didn't test for enum variants reexports, so here we are.
I also think I'll do #148648 at the same time as #148547.
r? @lolbinarycat