Skip to content

std: sys: fs: uefi: Implement stat#148970

Merged
bors merged 1 commit intorust-lang:mainfrom
Ayush1325:uefi-fs-stat
Nov 18, 2025
Merged

std: sys: fs: uefi: Implement stat#148970
bors merged 1 commit intorust-lang:mainfrom
Ayush1325:uefi-fs-stat

Conversation

@Ayush1325
Copy link
Contributor

@Ayush1325 Ayush1325 commented Nov 15, 2025

  • Implement std::fs::metadata function.
  • Tested on qemu ovmf

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 15, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 15, 2025

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Ayush1325 Ayush1325 mentioned this pull request Nov 15, 2025
Open
@Ayush1325
Copy link
Contributor Author

Ayush1325 commented Nov 15, 2025

@rustbot label +O-UEFI

@rustbot rustbot added the O-UEFI UEFI label Nov 15, 2025
joboet
joboet requested changes Nov 18, 2025
View reviewed changes
library/std/src/sys/fs/uefi.rs Outdated
crate::ptr::null_mut(),
)
};
assert_eq!(r, r_efi::efi::Status::BUFFER_TOO_SMALL);
Copy link
Member

@joboet joboet Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think an assert is too strong here – maybe there was a device error that is reported here? I'd assert that the result is not OK and return any errors other than BUFFER_TOO_SMALL to the user.

Copy link
Contributor Author

@Ayush1325 Ayush1325 Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 18, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@Ayush1325
std: sys: fs: uefi: Implement stat
6106760 
- Implement std::fs::metadata function.
- Tested on qemu ovmf

Signed-off-by: Ayush Singh <ayush@beagleboard.org>
@Ayush1325
Copy link
Contributor Author

Ayush1325 commented Nov 18, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 18, 2025
@joboet
Copy link
Member

joboet commented Nov 18, 2025

@bors r+
r? joboet

@bors
Copy link
Collaborator

bors commented Nov 18, 2025

📌 Commit 6106760 has been approved by joboet

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2025
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 18, 2025
Merged
bors added a commit that referenced this pull request Nov 18, 2025
@bors
Auto merge of #149059 - GuillaumeGomez:rollup-s6m2mmy, r=GuillaumeGomez
3d461af 
Rollup of 4 pull requests

Successful merges:

 - #148970 (std: sys: fs: uefi: Implement stat)
 - #149020 (flush_delayed: add note about stashed diagnostics)
 - #149026 (Add test for href of reexported enum variant)
 - #149049 (compiletest: Use JSON "binary-format" to decide `//@ only-elf` and `//@ ignore-elf`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ff262bc into rust-lang:main Nov 18, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 18, 2025
rust-timer added a commit that referenced this pull request Nov 18, 2025
@rust-timer
Unrolled build for #148970
f332450 
Rollup merge of #148970 - Ayush1325:uefi-fs-stat, r=joboet

std: sys: fs: uefi: Implement stat

- Implement std::fs::metadata function.
- Tested on qemu ovmf
@Ayush1325 Ayush1325 deleted the uefi-fs-stat branch November 18, 2025 17:27
@Ayush1325 Ayush1325 mentioned this pull request Nov 20, 2025
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 20, 2025
@matthiaskrgr
Rollup merge of rust-lang#149123 - Ayush1325:uefi-fs-size-fix, r=Chri…
0b2d422 
…sDenton

std: sys: fs: uefi: Fix FileAttr size

- The underlying file size is represented by file_size field. The size field is just the size of structure since it is a C DST.
- Fixes bug created in rust-lang#148970

`@rustbot` label +O-UEFI
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 20, 2025
@matthiaskrgr
Rollup merge of rust-lang#149123 - Ayush1325:uefi-fs-size-fix, r=Chri…
df178d9 
…sDenton

std: sys: fs: uefi: Fix FileAttr size

- The underlying file size is represented by file_size field. The size field is just the size of structure since it is a C DST.
- Fixes bug created in rust-lang#148970

``@rustbot`` label +O-UEFI
rust-timer added a commit that referenced this pull request Nov 21, 2025
@rust-timer
Unrolled build for #149123
70cb0c7 
Rollup merge of #149123 - Ayush1325:uefi-fs-size-fix, r=ChrisDenton

std: sys: fs: uefi: Fix FileAttr size

- The underlying file size is represented by file_size field. The size field is just the size of structure since it is a C DST.
- Fixes bug created in #148970

``@rustbot`` label +O-UEFI
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Nov 30, 2025
@GuillaumeGomez
Rollup merge of rust-lang#148970 - Ayush1325:uefi-fs-stat, r=joboet
ecbb256 
std: sys: fs: uefi: Implement stat

- Implement std::fs::metadata function.
- Tested on qemu ovmf
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Nov 30, 2025
@bors
Auto merge of rust-lang#149059 - GuillaumeGomez:rollup-s6m2mmy, r=Gui…
11ebbf9 
…llaumeGomez

Rollup of 4 pull requests

Successful merges:

 - rust-lang#148970 (std: sys: fs: uefi: Implement stat)
 - rust-lang#149020 (flush_delayed: add note about stashed diagnostics)
 - rust-lang#149026 (Add test for href of reexported enum variant)
 - rust-lang#149049 (compiletest: Use JSON "binary-format" to decide `//@ only-elf` and `//@ ignore-elf`)

r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Dec 10, 2025
@bors
Auto merge of #149059 - GuillaumeGomez:rollup-s6m2mmy, r=GuillaumeGomez
83b6925 
Rollup of 4 pull requests

Successful merges:

 - rust-lang/rust#148970 (std: sys: fs: uefi: Implement stat)
 - rust-lang/rust#149020 (flush_delayed: add note about stashed diagnostics)
 - rust-lang/rust#149026 (Add test for href of reexported enum variant)
 - rust-lang/rust#149049 (compiletest: Use JSON "binary-format" to decide `//@ only-elf` and `//@ ignore-elf`)

r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rust that referenced this pull request Dec 10, 2025
@bors
Auto merge of rust-lang#149059 - GuillaumeGomez:rollup-s6m2mmy, r=Gui…
8fee667 
…llaumeGomez

Rollup of 4 pull requests

Successful merges:

 - rust-lang#148970 (std: sys: fs: uefi: Implement stat)
 - rust-lang#149020 (flush_delayed: add note about stashed diagnostics)
 - rust-lang#149026 (Add test for href of reexported enum variant)
 - rust-lang#149049 (compiletest: Use JSON "binary-format" to decide `//@ only-elf` and `//@ ignore-elf`)

r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol pushed a commit to Kobzol/rustc_codegen_cranelift that referenced this pull request Dec 29, 2025
@bors
Auto merge of #149059 - GuillaumeGomez:rollup-s6m2mmy, r=GuillaumeGomez
68b60ec 
Rollup of 4 pull requests

Successful merges:

 - rust-lang/rust#148970 (std: sys: fs: uefi: Implement stat)
 - rust-lang/rust#149020 (flush_delayed: add note about stashed diagnostics)
 - rust-lang/rust#149026 (Add test for href of reexported enum variant)
 - rust-lang/rust#149049 (compiletest: Use JSON "binary-format" to decide `//@ only-elf` and `//@ ignore-elf`)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Jan 17, 2026
@matthiaskrgr
Rollup merge of rust-lang#149123 - Ayush1325:uefi-fs-size-fix, r=Chri…
ce46679 
…sDenton

std: sys: fs: uefi: Fix FileAttr size

- The underlying file size is represented by file_size field. The size field is just the size of structure since it is a C DST.
- Fixes bug created in rust-lang#148970

``@rustbot`` label +O-UEFI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joboet joboet joboet requested changes

Assignees

@joboet joboet

Labels

O-UEFI UEFI S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Ayush1325 @rustbot @joboet @bors @ChrisDenton