Add allocator parameter to HashSet #148550
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
cramertj
commented
Nov 5, 2025
Member
|
r? libs-api |
Member
|
r? Amanieu |
Member
|
LGTM for the code, but I'm concerned about the potential type inference failures. Could you combine this into #148545 so that can do a single crater run for both? |
rust-bors bot
added a commit
that referenced
this pull request
Jan 8, 2026
Add allocator parameter to HashMap Hashbrown support originally added in rust-lang/hashbrown#133 Part of rust-lang/wg-allocators#7 ~See also: hashset support in #148550 (Edit: merged into this PR for crater)
github-actions bot
pushed a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Jan 12, 2026
Add allocator parameter to HashMap Hashbrown support originally added in rust-lang/hashbrown#133 Part of rust-lang/wg-allocators#7 ~See also: hashset support in rust-lang/rust#148550 (Edit: merged into this PR for crater)
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Jan 12, 2026
Add allocator parameter to HashMap Hashbrown support originally added in rust-lang/hashbrown#133 Part of rust-lang/wg-allocators#7 ~See also: hashset support in rust-lang/rust#148550 (Edit: merged into this PR for crater)
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Jan 12, 2026
Add allocator parameter to HashMap Hashbrown support originally added in rust-lang/hashbrown#133 Part of rust-lang/wg-allocators#7 ~See also: hashset support in rust-lang/rust#148550 (Edit: merged into this PR for crater)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hashbrown support originally added in rust-lang/hashbrown#133
Part of rust-lang/wg-allocators#7
See also: hashmap support in #148545