Skip to content

Add allocator parameter to HashMap #148545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 3 commits into from
Jan 8, 2026
Merged

Add allocator parameter to HashMap #148545

rust-bors merged 3 commits into from
Jan 8, 2026
+547 −264

Conversation

@cramertj
Copy link
Member

@cramertj cramertj commented Nov 5, 2025 •
edited
Loading

Hashbrown support originally added in rust-lang/hashbrown#133
Part of rust-lang/wg-allocators#7

See also: hashset support in #148550 (Edit: merged into this PR for crater)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 5, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 5, 2025

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

cramertj
cramertj commented Nov 5, 2025
View reviewed changes
@rust-log-analyzer

This comment was marked as resolved.

Sign in to view
@cramertj cramertj mentioned this pull request Nov 5, 2025
Closed
@ibraheemdev
Copy link
Member

ibraheemdev commented Nov 17, 2025

r? libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Nov 17, 2025
@rustbot rustbot assigned Amanieu and unassigned ibraheemdev Nov 17, 2025
@cramertj
Copy link
Member Author

cramertj commented Dec 29, 2025

@Amanieu requested a crater run on this PR in #148550 (comment) in order to check for inference failures.

@cramertj cramertj added the needs-crater This change needs a crater run to check for possible breakage in the ecosystem. label Dec 29, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 29, 2025

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@cramertj

This comment was marked as outdated.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Dec 29, 2025
@rust-bors
Auto merge of #148545 - cramertj:alloc-map, r=<try>
160eafe 
Add allocator parameter to HashMap
@rust-log-analyzer

This comment was marked as outdated.

Sign in to view
@cramertj
Copy link
Member Author

cramertj commented Dec 30, 2025

@bors try

rust-bors bot added a commit that referenced this pull request Dec 30, 2025
@rust-bors
Auto merge of #148545 - cramertj:alloc-map, r=<try>
c0a9760 
Add allocator parameter to HashMap
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors
Copy link
Contributor

rust-bors bot commented Dec 30, 2025

☀️ Try build successful (CI)
Build commit: c0a9760 (c0a9760914bada211f4924ee16d41ae1a366d2ba, parent: 67944d6bec6b8fbbc3870e5365ab73cf88a9de62)

@Amanieu
Copy link
Member

Amanieu commented Dec 30, 2025

@craterbot check

@craterbot
Copy link
Collaborator

craterbot commented Dec 30, 2025

👌 Experiment pr-148545 created and queued.
🤖 Automatically detected try build c0a9760
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 30, 2025
@craterbot craterbot added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Dec 30, 2025
@craterbot
Copy link
Collaborator

craterbot commented Jan 4, 2026

🚧 Experiment pr-148545 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

craterbot commented Jan 6, 2026

🎉 Experiment pr-148545 is completed!
📊 4 regressed and 3 fixed (771080 total)
📊 2046 spurious results on the retry-regressed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-148545/retry-regressed-list.txt ↩

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jan 6, 2026
@cramertj
Copy link
Member Author

cramertj commented Jan 7, 2026

@Amanieu I think this is ready to go. The failures look unrelated.

@Amanieu
Copy link
Member

Amanieu commented Jan 7, 2026

@bors r+

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 7, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 7, 2026

📌 Commit ef7616d has been approved by Amanieu

It is now in the queue for this repository.

@matthiaskrgr
Copy link
Member

matthiaskrgr commented Jan 8, 2026

@bors rollup=never (for perf)

@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors rust-bors bot added the merged-by-bors This PR was explicitly merged by bors. label Jan 8, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 8, 2026

☀️ Test successful - CI
Approved by: Amanieu
Pushing 31cd367 to main...

@rust-bors rust-bors bot merged commit 31cd367 into rust-lang:main Jan 8, 2026
13 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 8, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4586feb (parent) -> 31cd367 (this PR)

Test differences

Show 546 test diffs

546 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 31cd367b9ca1ce359268e7adf4ea540408c0ad85 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-apple-various: 4792.1s -> 3474.1s (-27.5%)
  2. x86_64-rust-for-linux: 3180.6s -> 2663.1s (-16.3%)
  3. pr-check-1: 2015.1s -> 1690.2s (-16.1%)
  4. x86_64-gnu-tools: 3684.7s -> 3209.9s (-12.9%)
  5. i686-gnu-2: 5920.7s -> 5206.6s (-12.1%)
  6. aarch64-apple: 10839.5s -> 9563.9s (-11.8%)
  7. dist-aarch64-apple: 7968.5s -> 7081.1s (-11.1%)
  8. x86_64-gnu-gcc: 3776.5s -> 3362.2s (-11.0%)
  9. pr-check-2: 2592.8s -> 2311.1s (-10.9%)
  10. dist-aarch64-llvm-mingw: 5750.2s -> 6355.9s (+10.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

rust-timer commented Jan 9, 2026

Finished benchmarking commit (31cd367): comparison URL.

Overall result: ❌ regressions - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 0.3% [0.2%, 0.5%] 3
Regressions ❌
(secondary)		 0.5% [0.5%, 0.5%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.3% [0.2%, 0.5%] 3

Max RSS (memory usage)

Results (primary -1.7%, secondary -0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.0% [2.0%, 2.0%] 1
Improvements ✅
(primary)		 -1.7% [-2.3%, -1.1%] 2
Improvements ✅
(secondary)		 -1.3% [-1.4%, -1.2%] 2
All ❌✅ (primary) -1.7% [-2.3%, -1.1%] 2

Cycles

Results (secondary -2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.2% [-2.2%, -2.2%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 478.143s -> 474.812s (-0.70%)
Artifact size: 390.88 MiB -> 390.90 MiB (0.01%)

@rustbot rustbot added the perf-regression Performance regression. label Jan 9, 2026
@Mark-Simulacrum Mark-Simulacrum added the perf-regression-triaged The performance regression has been triaged. label Jan 12, 2026
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Jan 12, 2026

This seems expected to cause some regressions. I'm actually rather surprised they're not larger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Amanieu Amanieu

Labels

merged-by-bors This PR was explicitly merged by bors. needs-crater This change needs a crater run to check for possible breakage in the ecosystem. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

9 participants

@cramertj @rustbot @rust-log-analyzer @ibraheemdev @Amanieu @craterbot @matthiaskrgr @rust-timer @Mark-Simulacrum