don't normalize where-clauses when checking well-formedness#148477
don't normalize where-clauses when checking well-formedness#148477bors merged 4 commits intorust-lang:mainfrom
Conversation
|
@bors try |
This comment has been minimized.
This comment has been minimized.
crater: don't normalize where-clauses when checking well-formedness
|
@craterbot check |
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
🎉 Experiment
Footnotes
|
|
☔ The latest upstream changes (presumably #139558) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Affected projects: 2 dependencies of
|
|
I think we should also stop normalizing in rust/compiler/rustc_hir_analysis/src/check/wfcheck.rs Lines 1154 to 1163 in a7b3715 |
|
And probably these from the default args as well, right? |
This comment has been minimized.
This comment has been minimized.
|
wrt to normalizing obligations for default params before proving them 😅 we do need to normalize obligations before proving them in the old solver and this already doesn't normalize rust/compiler/rustc_middle/src/ty/predicate.rs Lines 125 to 127 in 5dbf406 The only "issue" is when normalizing obligations (or types - which we currently sometimes do intentionally because of implied bounds stuff) before checking that the obligation is well-formed, and this only happens before calling |
|
@bors try |
This comment has been minimized.
This comment has been minimized.
crater: don't normalize where-clauses when checking well-formedness
|
@craterbot check |
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
🎉 Experiment
Footnotes
|
The same 3 regressions were in the new runs above, and the spurious results are down to 32. |
|
@bors r=lcnr,BoxyUwU |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing c4dc70e (parent) -> 2a3a62d (this PR) Test differencesShow 6 test diffsStage 1
Stage 2
Additionally, 3 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 2a3a62d26e9e5badb806ac6a43bb307ff472b514 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (2a3a62d): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 0.2%, secondary 0.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 5.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.0%, secondary 0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 473.76s -> 472.42s (-0.28%) |
Pkgsrc changes: * Update version & checksums. * Adapt patches to new vendored crates. This has so far just been verified to build on NetBSD/amd64. Upstream changes relative to 1.93.1: Version 1.94.0 (2026-03-05) ========================== Language -------- - [Impls and impl items inherit `dead_code` lint level of the corresponding traits and trait items] (rust-lang/rust#144113) - [Stabilize additional 29 RISC-V target features including large portions of the RVA22U64 / RVA23U64 profiles] (rust-lang/rust#145948) - [Add warn-by-default `unused_visibilities` lint for visibility on `const _` declarations] (rust-lang/rust#147136) - [Update to Unicode 17] (rust-lang/rust#148321) - [Avoid incorrect lifetime errors for closures] (rust-lang/rust#148329) Platform Support ---------------- - [Add `riscv64im-unknown-none-elf` as a tier 3 target] (rust-lang/rust#148790) Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. [platform-support-doc]: https://doc.rust-lang.org/rustc/platform-support.html Libraries --------- - [Relax `T: Ord` bound for some `BinaryHeap<T>` methods.] (rust-lang/rust#149408) Stabilized APIs --------------- - [`<[T]>::array_windows`] (https://doc.rust-lang.org/stable/std/primitive.slice.html#method.array_windows) - [`<[T]>::element_offset`] (https://doc.rust-lang.org/stable/std/primitive.slice.html#method.element_offset) - [`LazyCell::get`] (https://doc.rust-lang.org/stable/std/cell/struct.LazyCell.html#method.get) - [`LazyCell::get_mut`] (https://doc.rust-lang.org/stable/std/cell/struct.LazyCell.html#method.get_mut) - [`LazyCell::force_mut`] (https://doc.rust-lang.org/stable/std/cell/struct.LazyCell.html#method.force_mut) - [`LazyLock::get`] (https://doc.rust-lang.org/stable/std/sync/struct.LazyLock.html#method.get) - [`LazyLock::get_mut`] (https://doc.rust-lang.org/stable/std/sync/struct.LazyLock.html#method.get_mut) - [`LazyLock::force_mut`] (https://doc.rust-lang.org/stable/std/sync/struct.LazyLock.html#method.force_mut) - [`impl TryFrom<char> for usize`] (https://doc.rust-lang.org/stable/std/convert/trait.TryFrom.html#impl-TryFrom%3Cchar%3E-for-usize) - [`std::iter::Peekable::next_if_map`] (https://doc.rust-lang.org/stable/std/iter/struct.Peekable.html#method.next_if_map) - [`std::iter::Peekable::next_if_map_mut`] (https://doc.rust-lang.org/stable/std/iter/struct.Peekable.html#method.next_if_map_mut) - [x86 `avx512fp16` intrinsics] (rust-lang/rust#127213) (excluding those that depend directly on the unstable `f16` type) - [AArch64 NEON fp16 intrinsics] (rust-lang/rust#136306) (excluding those that depend directly on the unstable `f16` type) - [`f32::consts::EULER_GAMMA`] (https://doc.rust-lang.org/stable/std/f32/consts/constant.EULER_GAMMA.html) - [`f64::consts::EULER_GAMMA`] (https://doc.rust-lang.org/stable/std/f64/consts/constant.EULER_GAMMA.html) - [`f32::consts::GOLDEN_RATIO`] (https://doc.rust-lang.org/stable/std/f32/consts/constant.GOLDEN_RATIO.html) - [`f64::consts::GOLDEN_RATIO`] (https://doc.rust-lang.org/stable/std/f64/consts/constant.GOLDEN_RATIO.html) These previously stable APIs are now stable in const contexts: - [`f32::mul_add`] (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.mul_add) - [`f64::mul_add`] (https://doc.rust-lang.org/stable/std/primitive.f64.html#method.mul_add) Cargo ----- - Stabilize the config include key. The top-level include config key allows loading additional config files, enabling better organization, sharing, and management of Cargo configurations across projects and environments. [docs] (https://doc.rust-lang.org/nightly/cargo/reference/config.html#including-extra-configuration-files) [#16284] (rust-lang/cargo#16284) - Stabilize the pubtime field in registry index. This records when a crate version was published and enables time-based dependency resolution in the future. Note that crates.io will gradually backfill existing packages when a new version is published. Not all crates have pubtime yet. [#16369] (rust-lang/cargo#16369) [#16372] (rust-lang/cargo#16372) - Cargo now parses [TOML v1.1](https://toml.io/en/v1.1.0) for manifests and configuration files. Note that using these features in Cargo.toml will raise your development MSRV, but the published manifest remains compatible with older parsers. [#16415] (rust-lang/cargo#16415) - [Make `CARGO_BIN_EXE_<crate>` available at runtime ] (rust-lang/cargo#16421) Compatibility Notes ------------------- - [Forbid freely casting lifetime bounds of `dyn`-types] (rust-lang/rust#136776) - [Make closure capturing have consistent and correct behaviour around patterns] (rust-lang/rust#138961) Some finer details of how precise closure captures get affected by pattern matching have been changed. In some cases, this can cause a non-move closure that was previously capturing an entire variable by move, to now capture only part of that variable by move, and other parts by borrow. This can cause the borrow checker to complain where it previously didn't, or cause `Drop` to run at a different point in time. - [Standard library macros are now imported via prelude, not via injected ` #[macro_use]`] (rust-lang/rust#139493) This will raise an error if macros of the same name are glob imported. For example if a crate defines their own `matches` macro and then glob imports that, it's now ambiguous whether the custom or standard library `matches` is meant and an explicit import of the name is required to resolve the ambiguity. One exception is `core::panic` and `std::panic`, if their import is ambiguous a new warning ([`ambiguous_panic_imports`] (rust-lang/rust#147319)) is raised. This may raise a new warning ([`ambiguous_panic_imports`] (rust-lang/rust#147319)) on `#![no_std]` code glob importing the std crate. Both `core::panic!` and `std::panic!` are then in scope and which is used is ambiguous. - [Don't strip shebang in expression-context `include!(…)`s] (rust-lang/rust#146377) This can cause previously working includes to no longer compile if they included files which started with a shebang. - [Ambiguous glob reexports are now also visible cross-crate] (rust-lang/rust#147984) This unifies behavior between local and cross-crate errors on these exports, which may introduce new ambiguity errors. - [Don't normalize where-clauses before checking well-formedness] (rust-lang/rust#148477) - [Introduce a future compatibility warning on codegen attributes on body-free trait methods] (rust-lang/rust#148756) These attributes currently have no effect in this position. - [On Windows `std::time::SystemTime::checked_sub_duration` will return `None` for times before the Windows epoch (1/1/1601)] (rust-lang/rust#148825) - [Lifetime identifiers such as `'a` are now NFC normalized] (rust-lang/rust#149192). - [Overhaul filename handling for cross-compiler consistency] (rust-lang/rust#149709) Any paths emitted by compiler now always respect the relative-ness of the paths and `--remap-path-prefix` given originally. One side-effect of this change is that paths emitted for local crates in Cargo (path dependencies and workspace members) are no longer absolute but relative when emitted as part of a diagnostic in a downstream crate. Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Switch to `annotate-snippets` for error emission] (rust-lang/rust#150032) This should preserve mostly the same outputs in rustc error messages.
WfCheck checks where-clauses after normalization, and we'd like to see what would break if it didn't for rust-lang/trait-system-refactor-initiative#255
r? ghost