Don't ICE if method receiver fails to unify with arbitrary_self_types#111860
Merged
bors merged 1 commit intorust-lang:masterfrom May 23, 2023
Merged
Don't ICE if method receiver fails to unify with arbitrary_self_types#111860bors merged 1 commit intorust-lang:masterfrom
arbitrary_self_types#111860bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
(rustbot has picked a reviewer for you, use r? to override) |
WaffleLapkin
approved these changes
May 23, 2023
Member
WaffleLapkin
left a comment
There was a problem hiding this comment.
as an ICE fix this looks fine
Member
|
@bors r+ |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 23, 2023
Rollup of 6 pull requests Successful merges: - rust-lang#111461 (Fix symbol conflict diagnostic mistakenly being shown instead of missing crate diagnostic) - rust-lang#111579 (Also assume wrap-around discriminants in `as` MIR building) - rust-lang#111704 (Remove return type sized check hack from hir typeck) - rust-lang#111853 (Check opaques for mismatch during writeback) - rust-lang#111854 (rustdoc: clean up `settings.css`) - rust-lang#111860 (Don't ICE if method receiver fails to unify with `arbitrary_self_types`) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider:
The problem here is that with
arbitrary_self_types, we're allowed to have a method receiver that mentions generics from the method itself (fn get<R: Deref<Target=Self>>(self: R)). Since we don't actually take into account the user-written turbofish generics when doing method lookup (nor do we check that method predicates hold), method probing will happily inferR = Fooduring the probe. When we later confirm the method, we do use the turbofish'd subst and instead now have thatR = &Foo. This doesn't unify with the self type we chose during the probe, causing an ICE.Getting this to work correctly will be difficult. Specifically, we'll need to actually pass in the turbofish generics for the method being probed for and check that the self type unifies considering those generics. This seems like a lot of work, and I'm not actually familiar with the restrictions originally called out for
#![feature(arbitrary_self_types)], but I think we should probably instead just deny having receivers that mention (type/const) generics that come from the method itself.But I mostly just want to turn this ICE into an error, so I'll leave that up for later PRs.
Fixes #111838