Fix symbol conflict diagnostic mistakenly being shown instead of missing crate diagnostic#111461
Merged
bors merged 1 commit intorust-lang:masterfrom May 23, 2023
Merged
Fix symbol conflict diagnostic mistakenly being shown instead of missing crate diagnostic#111461bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Contributor
Author
|
@rustbot ready |
Contributor
|
r=me after squashing commits. |
…ing crate diagnostic
Contributor
Author
|
@bors r=petrochenkov |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 23, 2023
Rollup of 6 pull requests Successful merges: - rust-lang#111461 (Fix symbol conflict diagnostic mistakenly being shown instead of missing crate diagnostic) - rust-lang#111579 (Also assume wrap-around discriminants in `as` MIR building) - rust-lang#111704 (Remove return type sized check hack from hir typeck) - rust-lang#111853 (Check opaques for mismatch during writeback) - rust-lang#111854 (rustdoc: clean up `settings.css`) - rust-lang#111860 (Don't ICE if method receiver fails to unify with `arbitrary_self_types`) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a refactoring mistake in #109213
fixes #111284