Use proper InferCtxt when probing for associated types in astconv#107100
Merged
bors merged 1 commit intorust-lang:masterfrom Jan 28, 2023
Merged
Use proper InferCtxt when probing for associated types in astconv#107100bors merged 1 commit intorust-lang:masterfrom
InferCtxt when probing for associated types in astconv#107100bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
r? @lcnr (rustbot has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
f93cdcb to
38bac4a
Compare
lcnr
reviewed
Jan 20, 2023
Contributor
lcnr
left a comment
There was a problem hiding this comment.
i really dislike this setup 😅 we should just have the right infcx available here.
Could we instead add a method fn infcx(&self) -> Option<&InferCtxt> to trait AstConv and use that here?
Contributor
There was a problem hiding this comment.
can you move the whole if let error reporting chain into a separate function (and module astconv/errors.rs). having this much error reporting in a function with relevant behavior makes it harder to read.
38bac4a to
5a6c63c
Compare
lcnr
reviewed
Jan 23, 2023
Comment on lines
2210
to
2212
Contributor
There was a problem hiding this comment.
can you add an assert that qself_ty does not have infer vars in this branch.
InferCtxt when probing for associated types in astconv
5a6c63c to
da3ecb0
Compare
Contributor
Author
|
@bors r=lcnr |
Collaborator
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 27, 2023
Use proper `InferCtxt` when probing for associated types in astconv Fixes rust-lang#107087
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 28, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#107022 (Implement `SpecOptionPartialEq` for `cmp::Ordering`) - rust-lang#107100 (Use proper `InferCtxt` when probing for associated types in astconv) - rust-lang#107103 (Use new solver in `evaluate_obligation` query (when new solver is enabled)) - rust-lang#107190 (Recover from more const arguments that are not wrapped in curly braces) - rust-lang#107306 (Correct suggestions for closure arguments that need a borrow) - rust-lang#107339 (internally change regions to be covariant) - rust-lang#107344 (Minor tweaks in the new solver) - rust-lang#107373 (Don't merge vtables when full debuginfo is enabled.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #107087