Implement SpecOptionPartialEq for cmp::Ordering#107022
Merged
bors merged 2 commits intorust-lang:masterfrom Jan 28, 2023
Merged
Implement SpecOptionPartialEq for cmp::Ordering#107022bors merged 2 commits intorust-lang:masterfrom
SpecOptionPartialEq for cmp::Ordering#107022bors merged 2 commits intorust-lang:masterfrom
Conversation
Collaborator
|
r? @m-ou-se (rustbot has picked a reviewer for you, use r? to override) |
This comment was marked as resolved.
This comment was marked as resolved.
lukas-code
reviewed
Jan 18, 2023
417262b to
3122db7
Compare
Member
|
It seems worrying that rustc/llvm didn't optimize this.
This PR seems fine for now (r=me), but can you please open an issue (if there isn't one already) and add a comment to |
Member
Author
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 28, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#107022 (Implement `SpecOptionPartialEq` for `cmp::Ordering`) - rust-lang#107100 (Use proper `InferCtxt` when probing for associated types in astconv) - rust-lang#107103 (Use new solver in `evaluate_obligation` query (when new solver is enabled)) - rust-lang#107190 (Recover from more const arguments that are not wrapped in curly braces) - rust-lang#107306 (Correct suggestions for closure arguments that need a borrow) - rust-lang#107339 (internally change regions to be covariant) - rust-lang#107344 (Minor tweaks in the new solver) - rust-lang#107373 (Don't merge vtables when full debuginfo is enabled.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 11, 2024
Remove an unneeded helper from the tuple library code Thanks to rust-lang#107022, this is just what `==` does, so we don't need the helper here anymore.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 11, 2024
…riplett Remove an unneeded helper from the tuple library code Thanks to rust-lang#107022, this is just what `==` does, so we don't need the helper here anymore.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 11, 2024
Rollup merge of rust-lang#118307 - scottmcm:tuple-eq-simpler, r=joshtriplett Remove an unneeded helper from the tuple library code Thanks to rust-lang#107022, this is just what `==` does, so we don't need the helper here anymore.
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Apr 7, 2024
Remove an unneeded helper from the tuple library code Thanks to rust-lang/rust#107022, this is just what `==` does, so we don't need the helper here anymore.
RalfJung
pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 27, 2024
Remove an unneeded helper from the tuple library code Thanks to rust-lang/rust#107022, this is just what `==` does, so we don't need the helper here anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed as I continue to explore options for having code using
partial_cmpoptimize better.Before:
After:
(Which https://alive2.llvm.org/ce/z/-rop5r says LLVM could just do itself, but there's probably an issue already open for that problem from when this was originally looked at for
Option<NonZeroU8>and friends.)