Add new bootstrap members to triagebot.toml#107029
Conversation
|
(rustbot has picked a reviewer for you, use r? to override) |
Yes, I would like to. |
9f728bc to
1c2b53d
Compare
jyn514
left a comment
There was a problem hiding this comment.
Should a T-bootstrap label be created, since src/tools/tidy is assigned to the bootstrap members, but labeled A-testsuite (and not A-bootstrap) ?
I think renaming A-bootstrap to T-bootstrap is fine, but I don't think we need a special label just to distinguish tidy - if you're not comfortable reviewing changes to it, you can assign Mark directly without assigning the whole bootstrap team.
|
I meant that now, the tidy tool is assigned to the bootstrap ad-hoc team, but currently gets the A-testsuite label. It is the case with others parts, I gave tidy as an example. |
|
My question to you is: are those tools you're interested in working on? :) Bootstrap does not have a formal mandate and "build system" is quite broad. If you want to be involved in those tools, I think labeling them as bootstrap is totally fine. If you don't want to be involved in those tools, I think removing the bootstrap team from the list of reviewers is also totally fine. I would be curious to hear if @Mark-Simulacrum has opinions on whether tidy/compiletest/rust-installer should be under T-bootstrap's mandate or not. |
1c2b53d to
9487686
Compare
|
I would move tidy to the T-bootstrap team, and leave the rest in the A-testsuite label, maybe additionally adding the T-bootstrap label. If I read
Some of the tools labeled as |
|
That sounds reasonable to me :) |
|
What is the process for the rename of the |
|
Done just now :) (if you need to do this yourself, I went to https://github.com/rust-lang/rust/labels?q=bootstrap in the web interface and clicked the edit button) |
51952b0 to
e17d413
Compare
|
I would have done that once the autolabel is changed, but I do not have write rights to the rust repo. @ozkanonur and @Mark-Simulacrum do you have thoughts ? |
I think tidy should either not assign bootstrap members or be labeled as p.s: rustbot gets confused by |
e17d413 to
fa7d17d
Compare
|
I reverted the tidy label move. |
|
@bors r+ rollup |
…ulacrum Add new bootstrap members to triagebot.toml `@ozkanonur` if you want to be assigned to review PRs too, just post a message to this thread. Should a `T-bootstrap` label be created, since `src/tools/tidy` is assigned to the `bootstrap` members, but labeled `A-testsuite` (and not `A-bootstrap`) ? cc `@jyn514`
…ulacrum Add new bootstrap members to triagebot.toml ``@ozkanonur`` if you want to be assigned to review PRs too, just post a message to this thread. Should a `T-bootstrap` label be created, since `src/tools/tidy` is assigned to the `bootstrap` members, but labeled `A-testsuite` (and not `A-bootstrap`) ? cc ``@jyn514``
…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#103418 (Add `SEMICOLON_IN_EXPRESSIONS_FROM_MACROS` to future-incompat report) - rust-lang#106113 (llvm-wrapper: adapt for LLVM API change) - rust-lang#106144 (Improve the documentation of `black_box`) - rust-lang#106578 (Label closure captures/generator locals that make opaque types recursive) - rust-lang#106749 (Update cc to 1.0.77) - rust-lang#106935 (Fix `SingleUseLifetime` ICE) - rust-lang#107015 (Re-enable building rust-analyzer on riscv64) - rust-lang#107029 (Add new bootstrap members to triagebot.toml) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
I've updated the |
@ozkanonur if you want to be assigned to review PRs too, just post a message to this thread.
Should a
T-bootstraplabel be created, sincesrc/tools/tidyis assigned to thebootstrapmembers, but labeledA-testsuite(and notA-bootstrap) ?cc @jyn514